diff options
| author | Nick Mathewson <nickm@torproject.org> | 2008-02-21 04:30:14 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2008-02-21 04:30:14 +0000 |
| commit | 063ced890373c1327b521ffc2481f609c58ea4d7 (patch) | |
| tree | 9a479de5e348f09ba608da8766f5a722fd88b259 /src/or/command.c | |
| parent | 47e6247673e4d47f30467e78897c5364320e860b (diff) | |
| download | tor-063ced890373c1327b521ffc2481f609c58ea4d7.tar tor-063ced890373c1327b521ffc2481f609c58ea4d7.tar.gz | |
r18296@catbus: nickm | 2008-02-20 23:30:11 -0500
Answer one xxx020 item; move 7 other ones to a new "XXX020rc" category: they should get fixed before we cut a release candidate. arma: please review these to see whether you have fixes/answers for any. Please check out the other 14 XXX020s to see if any look critical for the release candidate.
svn:r13640
Diffstat (limited to 'src/or/command.c')
| -rw-r--r-- | src/or/command.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/or/command.c b/src/or/command.c index 5da9316f1..66723d4dd 100644 --- a/src/or/command.c +++ b/src/or/command.c @@ -478,7 +478,8 @@ command_process_versions_cell(var_cell_t *cell, or_connection_t *conn) connection_mark_for_close(TO_CONN(conn)); return; } else if (highest_supported_version == 1) { - /*XXXXX020 consider this carefully. */ + /* Negotiating version 1 makes no sense, since version 1 has no VERSIONS + * cells. */ log_fn(LOG_PROTOCOL_WARN, LD_OR, "Used version negotiation protocol to negotiate a v1 connection. " "That's crazily non-compliant. Closing connection."); |