aboutsummaryrefslogtreecommitdiff
path: root/src/or/buffers.c
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2013-05-15 03:34:37 -0400
committerRoger Dingledine <arma@torproject.org>2013-05-15 03:34:37 -0400
commit0bfaf86612eddbd586d648f3b642dac26f134fca (patch)
tree494e8a2f9c917f28ccf0cf2ee397d816de36f8be /src/or/buffers.c
parentaaa3a085db05c4d98b7c51b5ef16da166e7c7f0a (diff)
downloadtor-0bfaf86612eddbd586d648f3b642dac26f134fca.tar
tor-0bfaf86612eddbd586d648f3b642dac26f134fca.tar.gz
Fix socks5 handshake for username/password auth
The fix for bug 8117 exposed this bug, and it turns out real-world applications like Pidgin do care. Bugfix on 0.2.3.2-alpha; fixes bug 8879.
Diffstat (limited to 'src/or/buffers.c')
-rw-r--r--src/or/buffers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/buffers.c b/src/or/buffers.c
index d063d2313..c4c847ec8 100644
--- a/src/or/buffers.c
+++ b/src/or/buffers.c
@@ -1751,7 +1751,7 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req,
return 0;
}
req->replylen = 2; /* 2 bytes of response */
- req->reply[0] = 5;
+ req->reply[0] = 1; /* authversion == 1 */
req->reply[1] = 0; /* authentication successful */
log_debug(LD_APP,
"socks5: Accepted username/password without checking.");