diff options
| author | Nick Mathewson <nickm@torproject.org> | 2013-06-12 12:04:33 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-06-12 12:04:33 -0400 |
| commit | f455686b77e4ac686251c6edf1f4a506a369866c (patch) | |
| tree | 72f904cc2464b984cc4c872c8e079abfa359bdf7 /changes | |
| parent | fff9386af87bd0f54cda1ef4fe0bf131de7c3d8e (diff) | |
| download | tor-f455686b77e4ac686251c6edf1f4a506a369866c.tar tor-f455686b77e4ac686251c6edf1f4a506a369866c.tar.gz | |
Unmap the microdescriptor cache before replacing it.
This is a reprise of the fix in bdff7e3299d78; 6905c1f6 reintroduced
that bug. Briefly: windows doesn't seem to like deleting a mapped
file. I tried adding the PROT_SHARED_DELETE flag to the createfile
all, but that didn't actually fix this issue. Fortunately, the unit
test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should
prevent us from making this particular screw-up again.
This patch also tries to limit the crash potential of a failure to
write by a little bit, although it could do a better job of retaining
microdescriptor bodies.
Fix for bug 8822, bugfix on 0.2.4.12-alpha.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug8822 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug8822 b/changes/bug8822 new file mode 100644 index 000000000..c6787afe0 --- /dev/null +++ b/changes/bug8822 @@ -0,0 +1,5 @@ + o Major bugfixes (windows): + - Prevent failures on Windows Vista and later when rebuilding the + microdescriptor cache. Diagnosed by Robert Ransom. Fixes bug 8822; + bugfix on 0.2.4.12-alpha. + |