diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-07-18 10:14:14 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-07-18 10:14:14 -0400 |
| commit | b355ddb20f534d772dcb42737ceb1d0264e2c3f1 (patch) | |
| tree | 5bf4f320dff8263d2168454207aeb63f85ec962e /changes | |
| parent | 4cac5df5548e0051a6927a778da3e6f01f45dc56 (diff) | |
| parent | 78dec943074c26747abc7a68cd6aec5269100569 (diff) | |
| download | tor-b355ddb20f534d772dcb42737ceb1d0264e2c3f1.tar tor-b355ddb20f534d772dcb42737ceb1d0264e2c3f1.tar.gz | |
Merge branch 'smartlist_shorten' into maint-0.2.3
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/smartlist_foreach | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/smartlist_foreach b/changes/smartlist_foreach new file mode 100644 index 000000000..2fd3a1a85 --- /dev/null +++ b/changes/smartlist_foreach @@ -0,0 +1,8 @@ + o Code simplification and refactoring: + - Do not use SMARTLIST_FOREACH for any loop whose body exceeds + 10 lines. Doing so in the past has led to hard-to-debug code. + The new style is to use the SMARTLIST_FOREACH_{BEGIN,END} pair. + Issue 6400. + - Do not nest SMARTLIST_FOREACH blocks within one another. Any + nested block ought to be using SMARTLIST_FOREACH_{BEGIN,END}. + Issue 6400. |