diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-05-11 17:00:41 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-05-11 17:16:29 -0400 |
| commit | 35d08e30d89e5882b708a2cc6cb728f5393b2528 (patch) | |
| tree | e07630bfeb3d681c04e9290ae53288e9308de7f1 /changes | |
| parent | 4bac2233116f0d94fd6ad1e77acb0baceeaf2336 (diff) | |
| download | tor-35d08e30d89e5882b708a2cc6cb728f5393b2528.tar tor-35d08e30d89e5882b708a2cc6cb728f5393b2528.tar.gz | |
An attempt at bug3940 and making AllowDotExit 0 work with MapAddress
This time, I follow grarpamp's suggestion and move the check for
.exit+AllowDotExit 0 to the top of connection_ap_rewrite_and_attach,
before any rewriting occurs. This way, .exit addresses are
forbidden as they arrive from a socks connection or a DNSPort
request, and not otherwise.
It _is_ a little more complicated than that, though. We need to
treat any .exit addresses whose source is TrackHostExits as meaning
that we can retry without that exit. We also need to treat any
.exit address that comes from an AutomapHostsOnResolve operation as
user-provided (and thus forbidden if AllowDotExits==0), so that
transitioning from AllowDotExits==1 to AllowDotExits==0 will
actually turn off automapped .exit addresses.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug3940_redux | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug3940_redux b/changes/bug3940_redux new file mode 100644 index 000000000..7733740d9 --- /dev/null +++ b/changes/bug3940_redux @@ -0,0 +1,5 @@ + o Major bugfixes: + - Change the AllowDotExit rules so they should actually work. + We now enforce AllowDotExit only immediately after receiving + an address via SOCKS or DNSPort: other sources are free to provide + .exit addresses after the resolution occurs. |