diff options
| author | Nick Mathewson <nickm@torproject.org> | 2013-06-10 12:14:49 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-06-10 12:14:49 -0400 |
| commit | 77a193533966c5c2f81e6a85b3c2a7446076508f (patch) | |
| tree | 17d934a20d1fe2b5b56bc5326676183367e4e30c /changes/bug9017 | |
| parent | 96d3219176398f377dc4a1c84e14a54e7d2516df (diff) | |
| download | tor-77a193533966c5c2f81e6a85b3c2a7446076508f.tar tor-77a193533966c5c2f81e6a85b3c2a7446076508f.tar.gz | |
Fix (Open?)BSD fast-connect bug with optimistic data.
There's an assertion failure that can occur if a connection has
optimistic data waiting, and then the connect() call returns 0 on the
first attempt (rather than -1 and EINPROGRESS). That latter behavior
from connect() appears to be an (Open?)BSDism when dealing with remote
addresses in some cases. (At least, I've only seen it reported with
the BSDs under libevent, even when the address was 127.0.0.1. And
we've only seen this problem in Tor with OpenBSD.)
Fixes bug 9017; bugfix on 0.2.3.1-alpha, which first introduced
optimistic data. (Although you could also argue that the commented-out
connection_start_writing in 155c9b80 back in 2002 is the real source
of the issue.)
Diffstat (limited to 'changes/bug9017')
| -rw-r--r-- | changes/bug9017 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/bug9017 b/changes/bug9017 new file mode 100644 index 000000000..359c526b0 --- /dev/null +++ b/changes/bug9017 @@ -0,0 +1,6 @@ + o Major bugfixes: + - Avoid an assertion failure on OpenBSD (and perhaps other BSDs) + when an exit connection with optimistic data succeeds immediately + rather than returning EINPROGRESS. Fixes bug 9017; bugfix on + 0.2.3.1-alpha. + |