diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-07-25 18:34:14 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-08-17 16:01:30 -0400 |
| commit | d9746bd468f551d1ada57d962b20eddd15256ce9 (patch) | |
| tree | 19bd19b957c825063431944d3dafe5c2e06c1f8b /changes/bug6468 | |
| parent | a9d56289ee53da6aa98a0c8b89796b7872ff6e1a (diff) | |
| download | tor-d9746bd468f551d1ada57d962b20eddd15256ce9.tar tor-d9746bd468f551d1ada57d962b20eddd15256ce9.tar.gz | |
Remove needless flush-on-write code.
Long ago, before we had cell queues, it was necessary to maybe call
connection_handle_write() from connectino_write_to_buf_impl() on OR
connections, so that we wouldn't get into a loop of reading infinite
amounts of data and queueing it all on an outbuf before bothering to
write any data.
If that doesn't sounds like what our code does now, you're right:
right now, we won't stick more than OR_CONN_HIGHWATER bytes of cells
on an outbuf, and we won't suck more than CELL_QUEUE_HIGHWATER_SIZE
cells off any edge connection. So, there's no more call for that
code.
Removing this code will simplify our data flow, and that should be
something we can all get behind.
Diffstat (limited to 'changes/bug6468')
| -rw-r--r-- | changes/bug6468 | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/bug6468 b/changes/bug6468 new file mode 100644 index 000000000..fb624da98 --- /dev/null +++ b/changes/bug6468 @@ -0,0 +1,8 @@ + o Minor bugfixes: + - Remove some now-needless code that tried to aggressively flush + OR connections as data was added to them. Since 0.2.0.1-alpha, + our cell queue logic has saved us from the failure mode that + this code was supposed to prevent. Removing this code will limit + the number of baroque control flow paths through Tor's network + logic. Reported pseudonymously on IRC. Fix for bug 6468; + bigfix on 0.2.0.1-alpha.
\ No newline at end of file |