diff options
author | Nick Mathewson <nickm@torproject.org> | 2011-07-01 12:06:54 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2011-07-01 12:54:24 -0400 |
commit | 959da6b7f2b5ed63426fd12a9046ac06033f6db1 (patch) | |
tree | 511cbbf99e04527081166fbb53a319b997f1bcc1 /LICENSE | |
parent | 46297bc7bd86826fa79195f36059ce408ef45b6c (diff) | |
download | tor-959da6b7f2b5ed63426fd12a9046ac06033f6db1.tar tor-959da6b7f2b5ed63426fd12a9046ac06033f6db1.tar.gz |
Use strlcpy in create_unix_sockaddr()
Using strncpy meant that if listenaddress were ever >=
sizeof(sockaddr_un.sun_path), we would fail to nul-terminate
sun_path. This isn't a big deal: we never read sun_path, and the
kernel is smart enough to reject the sockaddr_un if it isn't
nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we
should reject addresses that don't fit in sockaddr_un.sun_path.
Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha.
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions