aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2013-08-15 12:45:46 -0400
committerNick Mathewson <nickm@torproject.org>2013-11-18 10:43:15 -0500
commitc3ea946839704c4f1f0369a1e91bdb749991e346 (patch)
tree1e4fb8a3e30b62ebfbc5b20ba8d3e80c312c4675
parent56e3f056e9a03015aa55392a8028e2cbe097a0fb (diff)
downloadtor-c3ea946839704c4f1f0369a1e91bdb749991e346.tar
tor-c3ea946839704c4f1f0369a1e91bdb749991e346.tar.gz
Reseolve DOCDOC and XXXXs in backtrace.c
-rw-r--r--src/common/backtrace.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/src/common/backtrace.c b/src/common/backtrace.c
index 9c69e4f3f..78bc66efb 100644
--- a/src/common/backtrace.c
+++ b/src/common/backtrace.c
@@ -132,7 +132,6 @@ crash_handler(int sig, siginfo_t *si, void *ctx_)
static int
install_bt_handler(void)
{
- /*XXXX make this idempotent */
int trap_signals[] = { SIGSEGV, SIGILL, SIGFPE, SIGBUS, SIGSYS,
SIGIO, -1 };
int i, rv=0;
@@ -156,33 +155,30 @@ install_bt_handler(void)
static void
remove_bt_handler(void)
{
- /*XXXX writeme*/
+ /* We don't need to actually free anything at exit here. */
}
#endif
#ifdef NO_BACKTRACE_IMPL
-/**DOCDOC */
void
log_backtrace(int severity, int domain, const char *msg)
{
tor_log(severity, domain, "%s. (Stack trace not available)", msg);
}
-/**DOCDOC*/
static int
install_bt_handler(void)
{
return 0;
}
-/**DOCDOC*/
static void
remove_bt_handler(void)
{
}
#endif
-/**DOCDOC*/
+/** Set up code to handle generating error messages on crashes. */
int
configure_backtrace_handler(const char *tor_version)
{
@@ -194,7 +190,8 @@ configure_backtrace_handler(const char *tor_version)
return install_bt_handler();
}
-/**DOCDOC*/
+/** Perform end-of-process cleanup for code that generates error messages on
+ * crashes. */
void
clean_up_backtrace_handler(void)
{