diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-12-19 16:51:53 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-01-16 22:29:39 -0500 |
| commit | b7cf7bd9ae31aeddd03ad2094dd480d2b1d34d4f (patch) | |
| tree | 86b0e53db9405747d9e4cc1a0866db9ff9c194c6 | |
| parent | 65b90edbe4f456ee59c163e72bc75e522c4e9288 (diff) | |
| download | tor-b7cf7bd9ae31aeddd03ad2094dd480d2b1d34d4f.tar tor-b7cf7bd9ae31aeddd03ad2094dd480d2b1d34d4f.tar.gz | |
Fix an instance of snprintf; don't use _snprintf directly
| -rw-r--r-- | changes/7304 | 7 | ||||
| -rw-r--r-- | src/common/compat.h | 1 | ||||
| -rw-r--r-- | src/or/or.h | 1 | ||||
| -rw-r--r-- | src/or/routerparse.c | 2 |
4 files changed, 8 insertions, 3 deletions
diff --git a/changes/7304 b/changes/7304 new file mode 100644 index 000000000..bfb797b10 --- /dev/null +++ b/changes/7304 @@ -0,0 +1,7 @@ + o Minor bugfixes: + - Replace all calls to snprintf outside of src/ext with tor_snprintf. + Fix for bug 7304. + o Code simplification and refactoring: + - Remove the #define to replace snprintf with _snprintf on windows; + they have different semantics, and all of our callers should be + using tor_snprintf anyway. Partial fix for bug 7304. diff --git a/src/common/compat.h b/src/common/compat.h index 86ea0c41d..630682e63 100644 --- a/src/common/compat.h +++ b/src/common/compat.h @@ -59,7 +59,6 @@ #include <io.h> #include <math.h> #include <projects.h> -#define snprintf _snprintf /* this is not exported as W .... */ #define SHGetPathFromIDListW SHGetPathFromIDList /* wcecompat has vasprintf */ diff --git a/src/or/or.h b/src/or/or.h index 459e18e46..6ec7c3a79 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -81,7 +81,6 @@ #include <process.h> #include <direct.h> #include <windows.h> -#define snprintf _snprintf #endif #ifdef USE_BUFFEREVENTS diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 1aee4e533..48744d699 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -3828,7 +3828,7 @@ get_next_token(memarea_t *area, if ((size_t)(eol-next) != 9+obname_len+5 || strcmp_len(next+9, tok->object_type, obname_len) || strcmp_len(eol-5, "-----", 5)) { - snprintf(ebuf, sizeof(ebuf), "Malformed object: mismatched end tag %s", + tor_snprintf(ebuf, sizeof(ebuf), "Malformed object: mismatched end tag %s", tok->object_type); ebuf[sizeof(ebuf)-1] = '\0'; RET_ERR(ebuf); |