aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2012-09-06 11:05:16 -0400
committerNick Mathewson <nickm@torproject.org>2012-09-06 11:05:16 -0400
commitad1e8b45df3933e6f01098a5f9ba6238adafc9c2 (patch)
tree1e5faa0bb69a8fbbcc74ed175e3a92e504c58bed
parente9684405acf5d3bbfa3c2d4f70332cef3c66d553 (diff)
parent30fe9080e70aa2ebdf1c2bf86e98fe46b1ad27e1 (diff)
downloadtor-ad1e8b45df3933e6f01098a5f9ba6238adafc9c2.tar
tor-ad1e8b45df3933e6f01098a5f9ba6238adafc9c2.tar.gz
Merge branch 'bug6778'
-rw-r--r--changes/bug67786
-rw-r--r--src/common/include.am12
-rw-r--r--src/or/include.am15
3 files changed, 21 insertions, 12 deletions
diff --git a/changes/bug6778 b/changes/bug6778
new file mode 100644
index 000000000..9149f70ea
--- /dev/null
+++ b/changes/bug6778
@@ -0,0 +1,6 @@
+ o Minor bugfixes:
+ - Avoid a warning when building common_sha1.i out of tree. Fixes bug
+ 6778; bugfix on 0.2.4.1-alpha.
+ - Fix mis-declared dependencies on src/common/crypto.c and
+ src/or/tor_main.c that could break out-of-tree builds under some
+ circumstances. Fixes bug 6778; bugfix on 0.2.4.1-alpha.
diff --git a/src/common/include.am b/src/common/include.am
index 0ab476984..299c92e06 100644
--- a/src/common/include.am
+++ b/src/common/include.am
@@ -36,7 +36,7 @@ src_common_libor_crypto_a_SOURCES = \
src_common_libor_event_a_SOURCES = src/common/compat_libevent.c
-noinst_HEADERS+= \
+COMMONHEADERS = \
src/common/address.h \
src/common/aes.h \
src/common/ciphers.inc \
@@ -57,17 +57,19 @@ noinst_HEADERS+= \
src/common/tortls.h \
src/common/util.h
+noinst_HEADERS+= $(COMMONHEADERS)
+
DISTCLEANFILES+= src/common/common_sha1.i
-src/common/common_sha1.i: $(libor_SOURCES) $(libor_crypto_a_SOURCES) $(noinst_HEADERS)
+src/common/common_sha1.i: $(libor_SOURCES) $(libor_crypto_a_SOURCES) $(COMMONHEADERS)
$(AM_V_GEN)if test "@SHA1SUM@" != none; then \
- (cd "$(srcdir)" && "@SHA1SUM@" $(src_common_libor_SOURCES) $(src_common_libor_crypto_a_SOURCES) $(noinst_HEADERS)) | "@SED@" -n 's/^\(.*\)$$/"\1\\n"/p' > $@; \
+ (cd "$(srcdir)" && "@SHA1SUM@" $(src_common_libor_SOURCES) $(src_common_libor_crypto_a_SOURCES) $(COMMONHEADERS)) | "@SED@" -n 's/^\(.*\)$$/"\1\\n"/p' > $@; \
elif test "@OPENSSL@" != none; then \
- (cd "$(srcdir)" && "@OPENSSL@" sha1 $(src_common_libor_SOURCES) $(src_Common_libor_crypto_a_SOURCES) $(noinst_HEADERS)) | "@SED@" -n 's/SHA1(\(.*\))= \(.*\)/"\2 \1\\n"/p' > $@; \
+ (cd "$(srcdir)" && "@OPENSSL@" sha1 $(src_common_libor_SOURCES) $(src_Common_libor_crypto_a_SOURCES) $(COMMONHEADERS)) | "@SED@" -n 's/SHA1(\(.*\))= \(.*\)/"\2 \1\\n"/p' > $@; \
else \
rm $@; \
touch $@; \
fi
src/common/util_codedigest.o: src/common/common_sha1.i
-src/common/crypto.c: src/common/sha256.c
+src/common/crypto.o: src/common/sha256.c
diff --git a/src/or/include.am b/src/or/include.am
index 65ff68492..97072dce2 100644
--- a/src/or/include.am
+++ b/src/or/include.am
@@ -64,7 +64,7 @@ src_or_libtor_a_SOURCES = \
src_or_tor_SOURCES = src/or/tor_main.c
AM_CPPFLAGS += -I$(srcdir)/src/or -Isrc/or
-src/or/tor_main.c: micro-revision.i
+src/or/tor_main.o: micro-revision.i
AM_CPPFLAGS += -DSHARE_DATADIR="\"$(datadir)\"" \
-DLOCALSTATEDIR="\"$(localstatedir)\"" \
@@ -81,7 +81,7 @@ src_or_tor_LDADD = src/or/libtor.a src/common/libor.a src/common/libor-crypto.a
@TOR_ZLIB_LIBS@ @TOR_LIB_MATH@ @TOR_LIBEVENT_LIBS@ @TOR_OPENSSL_LIBS@ \
@TOR_LIB_WS32@ @TOR_LIB_GDI@
-noinst_HEADERS+= \
+ORHEADERS = \
src/or/buffers.h \
src/or/circuitbuild.h \
src/or/circuitlist.h \
@@ -122,8 +122,9 @@ noinst_HEADERS+= \
src/or/router.h \
src/or/routerlist.h \
src/or/routerparse.h \
- src/or/status.h \
- micro-revision.i
+ src/or/status.h
+
+noinst_HEADERS+= $(ORHEADERS) micro-revision.i
src/or/config_codedigest.o: src/or/or_sha1.i
@@ -143,12 +144,12 @@ micro-revision.i: FORCE
mv micro-revision.tmp micro-revision.i; \
fi; true
-src/or/or_sha1.i: $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES)
+src/or/or_sha1.i: $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES) $(ORHEADERS)
$(AM_V_GEN)if test "@SHA1SUM@" != none; then \
- (cd "$(srcdir)" && "@SHA1SUM@" $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES)) | \
+ (cd "$(srcdir)" && "@SHA1SUM@" $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES) $(ORHEADERS) ) | \
"@SED@" -n 's/^\(.*\)$$/"\1\\n"/p' > src/or/or_sha1.i; \
elif test "@OPENSSL@" != none; then \
- (cd "$(srcdir)" && "@OPENSSL@" sha1 $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES)) | \
+ (cd "$(srcdir)" && "@OPENSSL@" sha1 $(src_or_tor_SOURCES) $(src_or_libtor_a_SOURCES) $(ORHEADERS)) | \
"@SED@" -n 's/SHA1(\(.*\))= \(.*\)/"\2 \1\\n"/p' > src/or/or_sha1.i; \
else \
rm src/or/or_sha1.i; \