aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Kadianakis <desnacked@riseup.net>2014-05-01 14:44:29 +0100
committerNick Mathewson <nickm@torproject.org>2014-05-01 12:34:50 -0400
commita787575b7f2d9bbb8385940977cafcfc87c71234 (patch)
tree9f0930b96d607b57da1c1268a9ee1ed406a634c0
parent545e2119f2e96dedef2efd254632f0204f70ab76 (diff)
downloadtor-a787575b7f2d9bbb8385940977cafcfc87c71234.tar
tor-a787575b7f2d9bbb8385940977cafcfc87c71234.tar.gz
Fix a misuse of strlcpy() introduced by the #11156 patch.
-rw-r--r--changes/bug116544
-rw-r--r--src/or/nodelist.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/changes/bug11654 b/changes/bug11654
new file mode 100644
index 000000000..97c70b25d
--- /dev/null
+++ b/changes/bug11654
@@ -0,0 +1,4 @@
+ o Minor bugfixes:
+ - Fix a broken log message about delayed directory fetches that
+ was caused by a misuse of strlcpy(). Fixes bug 11654; bugfix on
+ 0.2.5.3-alpha.
diff --git a/src/or/nodelist.c b/src/or/nodelist.c
index a38a6d499..09232f9f9 100644
--- a/src/or/nodelist.c
+++ b/src/or/nodelist.c
@@ -1510,8 +1510,8 @@ update_router_have_minimum_dir_info(void)
}
if (should_delay_dir_fetches(get_options(), &delay_fetches_msg)) {
- log_notice(LD_DIR, "Delaying dir fetches: %s", delay_fetches_msg);
- strlcpy(dir_info_status, "%s", sizeof(dir_info_status));
+ log_notice(LD_DIR, "Delaying directory fetches: %s", delay_fetches_msg);
+ strlcpy(dir_info_status, delay_fetches_msg, sizeof(dir_info_status));
res = 0;
goto done;
}