aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-04-19 12:53:57 -0400
committerNick Mathewson <nickm@torproject.org>2014-04-19 12:53:57 -0400
commit78f555a2480b03911e602c2c041a10fd010804b9 (patch)
tree7cc302ce661f193893338af4be41829be4ea46c0
parent1800e79ca508e555d43eb8ca36e9544f42c98944 (diff)
downloadtor-78f555a2480b03911e602c2c041a10fd010804b9.tar
tor-78f555a2480b03911e602c2c041a10fd010804b9.tar.gz
scan-build: sizeof(ptr*) in a debugging log in ext_orport.c
Instead of taking the length of a buffer, we were taking the length of a pointer, so that our debugging log would cover only the first sizeof(void*) bytes of the client nonce.
-rw-r--r--src/or/ext_orport.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/ext_orport.c b/src/or/ext_orport.c
index d5a0fa1ee..0d28a9199 100644
--- a/src/or/ext_orport.c
+++ b/src/or/ext_orport.c
@@ -256,7 +256,7 @@ handle_client_auth_nonce(const char *client_nonce, size_t client_nonce_len,
base16_encode(server_nonce_encoded, sizeof(server_nonce_encoded),
server_nonce, sizeof(server_nonce));
base16_encode(client_nonce_encoded, sizeof(client_nonce_encoded),
- client_nonce, sizeof(client_nonce));
+ client_nonce, EXT_OR_PORT_AUTH_NONCE_LEN);
log_debug(LD_GENERAL,
"server_hash: '%s'\nserver_nonce: '%s'\nclient_nonce: '%s'",