| Commit message (Expand) | Author | Age |
|---|
| * | closures | Joey Hess | 2008-07-14 |
| * | fix link | Joey Hess | 2008-07-14 |
| * | web commit by http://ptecza.myopenid.com/: * Broken URL | Joey Hess | 2008-07-14 |
| * | Mark bug "clear: both for .page*?" as [[done]] | Simon McVittie | 2008-07-13 |
| * | web commit by http://smcv.pseudorandom.co.uk/: Patched | Joey Hess | 2008-07-13 |
| * | web commit by http://smcv.pseudorandom.co.uk/: on second thoughts, more chang... | Joey Hess | 2008-07-13 |
| * | web commit by http://smcv.pseudorandom.co.uk/: suggest solution | Joey Hess | 2008-07-13 |
| * | only htmlize errors when cgi is actually running | Joey Hess | 2008-07-12 |
| * | add perlmagick to build deps•••needed since the doc wiki is using an [[img]]
| Joey Hess | 2008-07-12 |
| * | Hopefully fix regression tests in non-English environments | Simon McVittie | 2008-07-12 |
| * | Merge branch 'master' of git://git.ikiwiki.info into bugs | Simon McVittie | 2008-07-12 |
| |\ |
|
| | * | web commit by http://smcv.pseudorandom.co.uk/: I think I know what's wrong he... | Joey Hess | 2008-07-12 |
| * | | Add missing requirement of IkiWiki::render before starting to render things | Simon McVittie | 2008-07-12 |
| |/ |
|
| * | web commit by http://smcv.pseudorandom.co.uk/ | Joey Hess | 2008-07-12 |
| * | web commit by intrigeri: initial bug submission | Joey Hess | 2008-07-12 |
| * | web commit by intrigeri: update, found a possible (random) fix | Joey Hess | 2008-07-12 |
| * | web commit by intrigeri: bug submission | Joey Hess | 2008-07-12 |
| * | web commit by intrigeri: bug submission | Joey Hess | 2008-07-12 |
| * | remove example (which was lacking escaping) | Joey Hess | 2008-07-12 |
| * | fixed | Joey Hess | 2008-07-12 |
| * | web commit by http://smcv.pseudorandom.co.uk/ | Joey Hess | 2008-07-12 |
| * | Change deb dependencies to list Text::Markdown before markdown, since the for... | Joey Hess | 2008-07-12 |
| * | greatly simplified test case | Joey Hess | 2008-07-12 |
| * | bug | Joey Hess | 2008-07-11 |
| * | web commit by intrigeri: thanks + note about git collaborative work | Joey Hess | 2008-07-11 |
| * | web commit by intrigeri: answer + fix escaping in example wiki page | Joey Hess | 2008-07-11 |
| * | question | Joey Hess | 2008-07-10 |
| * | escape | Joey Hess | 2008-07-10 |
| * | Fixes creation of pages when clicking on WikiLinks starting with "/". | Joey Hess | 2008-07-10 |
| * | web commit by intrigeri: initial bug submission | Joey Hess | 2008-07-10 |
| * | web commit by intrigeri: added opinion + patch | Joey Hess | 2008-07-10 |
| * | web commit by http://ptecza.myopenid.com/: * Confirmation and thanks | Joey Hess | 2008-07-09 |
| * | remove patch tag | Joey Hess | 2008-07-09 |
| * | close | Joey Hess | 2008-07-09 |
| * | close | Joey Hess | 2008-07-09 |
| * | response | Joey Hess | 2008-07-08 |
| * | web commit by AndrewGreenberg: bad formatting on bug report, sorry. | Joey Hess | 2008-07-08 |
| * | web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52. | Joey Hess | 2008-07-08 |
| * | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info•••Conflicts:
doc/bugs/attachment:_failed_to_get_filehandle.mdwn
| Joey Hess | 2008-07-08 |
| |\ |
|
| | * | web commit by http://ptecza.myopenid.com/: * Thanks! | Joey Hess | 2008-07-08 |
| | * | web commit by HenrikBrixAndersen: This happens on FreeBSD as well | Joey Hess | 2008-07-08 |
| * | | attachment: Support perl 5.8's buggy version of CGI.pm.•••This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
| Joey Hess | 2008-07-08 |
| |/ |
|
| * | reproduced | Joey Hess | 2008-07-08 |
| * | response | Joey Hess | 2008-07-08 |
| * | web commit by http://ptecza.myopenid.com/: * The bug still occurs | Joey Hess | 2008-07-08 |
| * | undef $fh before opening | Joey Hess | 2008-07-08 |
| * | web commit by http://ptecza.myopenid.com/: * Still no success | Joey Hess | 2008-07-08 |
| * | response | Joey Hess | 2008-07-08 |
| * | another try at dealing with CGI.pm problem•••open the temp file if all attempts to get a fd fail
| Joey Hess | 2008-07-08 |
| * | web commit by http://ptecza.myopenid.com/: * Debugging again | Joey Hess | 2008-07-08 |