| Commit message (Expand) | Author | Age |
|---|
| * | rename beautify_url to stress it only works on the path component | Joey Hess | 2008-07-11 |
| * | beautify url recentchanges_link redirs to•••This ensures that the same link is reached as is used on pages,
so browsers will know that the link on pages has been visited, and color it
appropriately.
| Joey Hess | 2008-07-11 |
| * | fix use ordering•••The recent setup revamp exposed some latent bugs in use/package ordering
that caused some symbols to not the exported into the correct scope.
| Joey Hess | 2008-07-11 |
| * | whitespace | Joey Hess | 2008-07-11 |
| * | Fixes creation of pages when clicking on WikiLinks starting with "/". | Joey Hess | 2008-07-10 |
| * | template: Add support for a BASENAME variable. | Joey Hess | 2008-07-10 |
| * | work around CGI::Session constructor issues•••The constructor can fail with a useless error message if module fail to
load. Work around this by evaling it, and checking for failures, and
printing CGI::Session->errstr to get a more useful message.
| Joey Hess | 2008-07-10 |
| * | clarifications, comments | Joey Hess | 2008-07-09 |
| * | Make it possible to load setup files w/o running them. Code needing to do so ... | Joey Hess | 2008-07-09 |
| * | improve error message if virus checker fails w/o output | Joey Hess | 2008-07-09 |
| * | otl: Support utf-8 files. (Recai Oktaş) | Joey Hess | 2008-07-08 |
| * | attachment: Support perl 5.8's buggy version of CGI.pm.•••This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
| Joey Hess | 2008-07-08 |
| * | explicitly set form type to multipart•••This is the default in unstable's formbuilder, but not in stable's,
and CGI multipart is needed for fule uploads.
| Joey Hess | 2008-07-08 |
| * | check for tempfile being empty | Joey Hess | 2008-07-08 |
| * | undef $fh before opening | Joey Hess | 2008-07-08 |
| * | another try at dealing with CGI.pm problem•••open the temp file if all attempts to get a fd fail
| Joey Hess | 2008-07-08 |
| * | attachment: Support old versions of CGI.pm that lack an upload method. | Joey Hess | 2008-07-08 |
| * | attachment: Fix an uninitialised value warning when editing a page that curre... | Joey Hess | 2008-07-08 |
| * | minor improvements | Joey Hess | 2008-07-07 |
| * | search: generate configuration files once only when rebuilding | Gabriel McManus | 2008-07-07 |
| * | add virus checking to attachments plugin | Joey Hess | 2008-07-06 |
| * | avoid uninitialised value warnings | Joey Hess | 2008-07-06 |
| * | avoid uninitialised value | Joey Hess | 2008-07-06 |
| * | editpage escaping fixes•••* The editpage form now uses the raw page name, not the page title, in its
'page' cgi parameter. Using the title was ambiguous and made it
impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
form.
| Joey Hess | 2008-07-06 |
| * | link to pagespec/attachment | Joey Hess | 2008-07-02 |
| * | factor out glob2re | Joey Hess | 2008-07-02 |
| * | add mimetype checking | Joey Hess | 2008-07-02 |
| * | add user and ip support to attachment pagespecs | Joey Hess | 2008-07-02 |
| * | toggle: Add javascript to top of page, not to end. This avoids flicker since ... | Joey Hess | 2008-07-02 |
| * | xhtml fixes | Joey Hess | 2008-07-02 |
| * | toggle: Add support for toggles that are open by default.•••Also fix to work in preview mode.
| Joey Hess | 2008-07-02 |
| * | attachments interface visibility toggling | Joey Hess | 2008-07-02 |
| * | export javascript, and support default-open toggles | Joey Hess | 2008-07-02 |
| * | fixes | Joey Hess | 2008-07-01 |
| * | some fit and finish fixes | Joey Hess | 2008-07-01 |
| * | only show one sig fig | Joey Hess | 2008-07-01 |
| * | display human sizes | Joey Hess | 2008-07-01 |
| * | add both kinds of links | Joey Hess | 2008-07-01 |
| * | basic attachment list | Joey Hess | 2008-07-01 |
| * | save attachments when page is saved too•••A user might specify an attachment, but not click the upload button,
and just save the whole page instead.
| Joey Hess | 2008-07-01 |
| * | check attachments in and refresh | Joey Hess | 2008-07-01 |
| * | add allowed attachments field to admin prefs | Joey Hess | 2008-07-01 |
| * | minor optimisation | Joey Hess | 2008-07-01 |
| * | fix expensive move code path | Joey Hess | 2008-07-01 |
| * | better approach for cgi upload disabling•••Make it a config setting, this way subtle load order issues don't come into
play. (As much?)
| Joey Hess | 2008-07-01 |
| * | bugfixes | Joey Hess | 2008-07-01 |
| * | attachment location•••Put the attachment in a subdir of the page it's attached to,
unless that page is an "index" page.
| Joey Hess | 2008-07-01 |
| * | simplification | Joey Hess | 2008-07-01 |
| * | reorder•••canedit should fail first as it's a less expensive and harder to pass test
| Joey Hess | 2008-07-01 |
| * | call check_canedit•••Needed to prevent uploads of locked pages as attachments.
| Joey Hess | 2008-07-01 |