| Commit message (Expand) | Author | Age |
* | avoid uninitialized value•••This can happen when a new field,
such as the new lasttry, is added.
| Joey Hess | 2008-12-19 |
* | fix comment permalink to always point to comment parent page | Joey Hess | 2008-12-19 |
* | remove cruft•••wtf does it do? absolutely nothing
| Joey Hess | 2008-12-19 |
* | rename comments_form to editcomment | Joey Hess | 2008-12-19 |
* | rename comments_display to comment | Joey Hess | 2008-12-19 |
* | replace discussion links on pages with comments link•••The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.
(Implementation is a bit optimised to avoid redundant pagespec checking.)
| Joey Hess | 2008-12-19 |
* | jump to comment after posting•••Jumping to the just posted comment was the imputus, but I killed a number
of birds here.
Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.
To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.
Got rid of the FIXMEd hardcoded html anchor div.
More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.
Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.
| Joey Hess | 2008-12-18 |
* | aggregate: If a feed fails to be downloaded, try again immediatly next time a... | Joey Hess | 2008-12-17 |
* | jump to comments anchor after post•••Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.
| Joey Hess | 2008-12-17 |
* | typo | Joey Hess | 2008-12-17 |
* | add Comments link when displaying a page inline•••This link will supplant the usual Discussion link for pages
that have comments enabled.
| Joey Hess | 2008-12-17 |
* | fix test when comments_closed_pagespec is empty | Joey Hess | 2008-12-17 |
* | change around comments pagespecs•••I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.
| Joey Hess | 2008-12-17 |
* | fix default values for config settings•••defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.
| Joey Hess | 2008-12-17 |
* | Coding style change: Remove explcit vim folding markers. | Joey Hess | 2008-12-17 |
* | checksessionexpiry: rework•••This function as factored out was a bit confusing, I think this makes more
sense.
| Joey Hess | 2008-12-17 |
* | Merge branch 'master' into comments | Joey Hess | 2008-12-17 |
|\ |
|
| * | monotone: When getting the log, tell monotone how many entries we want, rathe... | Joey Hess | 2008-12-17 |
| * | rename: Fix double-escaping of page name in edit box.•••titlepage normally escapes, but so does formbuilder.
| Joey Hess | 2008-12-17 |
| * | htmlbalance: don't compact whitespace, and set misc other options•••Not compacting whitespace is the most important one: now that we run
sanitize hooks on individual posted comments in the comments plugin,
whitespace that is significant to Markdown (but not HTML) is lost.
(cherry picked from commit cb5aaa3cee8b35d6fc6e88a7449a9477a6587c7a)
| Simon McVittie | 2008-12-12 |
* | | elide unnecessary variables | Joey Hess | 2008-12-12 |
* | | remove fixme•••sessioncgi hooks are always called with the wiki locked
| Joey Hess | 2008-12-12 |
* | | fix redefinition of $author | Joey Hess | 2008-12-12 |
* | | move related code together | Joey Hess | 2008-12-12 |
* | | whitespace | Joey Hess | 2008-12-12 |
* | | don't explicitly use inline•••loadplugin("inline") should take care of that
| Joey Hess | 2008-12-12 |
* | | avoid unnecessary variable | Joey Hess | 2008-12-12 |
* | | get rid of the [postcomment] hack•••I think that using a flag variable is sorta cleaner.
(This is untested.)
| Joey Hess | 2008-12-12 |
* | | move getsetup to usual place | Joey Hess | 2008-12-12 |
* | | Merge branch 'master' into comments | Joey Hess | 2008-12-12 |
|\| |
|
| * | meta: Pass info to htmlscrubber so htmlscrubber_skip can take effect. | Joey Hess | 2008-12-12 |
| * | simplifiy logic | Joey Hess | 2008-12-11 |
* | | comments: Store dates in GMT and in ISO-8601•••The [[!_comment]] directive is a serialization format, not something for
presentation to users, so we should use the least ambiguous possible
representation.
| Simon McVittie | 2008-12-12 |
* | | comments: Change internal-use-only directive from [[!comment]] to [[!_comment]] | Simon McVittie | 2008-12-11 |
* | | comments: Use new feedfile, emptyfeeds options to inline | Simon McVittie | 2008-12-11 |
* | | comments: don't interpolate IP into anonymous user's "name"•••If an admin wants the IP in the comment display template they can still
get it (the default template shows it).
| Simon McVittie | 2008-12-11 |
* | | comments: fix invocation of possibly_foolish_untaint | Simon McVittie | 2008-12-11 |
* | | comments: avoid warning if there's no subject | Simon McVittie | 2008-12-11 |
* | | comments: Optionally allow anonymous commenters to set their name/URL.•••Also provide a way for the comment template to pick up the verified
username/IP.
| Simon McVittie | 2008-12-11 |
* | | comments: Remove some dead code | Simon McVittie | 2008-12-11 |
* | | comments: rename main field to "editcontent" consistent with editpage•••This has the side-effect that Ikiwiki's default style.css gives the text
box 100% width.
| Simon McVittie | 2008-12-11 |
* | | comments: instead of hard-coding mdwn, allow any supported page format | Simon McVittie | 2008-12-11 |
* | | comments: Save comments as a file with one big [[!comment]] directive.•••This delays all comment formatting until the last possible time, allows
us to set metadata without worrying that commenters may be able to evade
it, and means that changes to how a comment is saved can be handled
gracefully. It also gives us somewhere to put the commenter's username
or IP address for later reference.
| Simon McVittie | 2008-12-11 |
* | | Remove dead code for preprocessing [[!comments]] | Simon McVittie | 2008-12-11 |
* | | comments: Duplicate logic and CGI hook from recentchanges to link user pages ... | Simon McVittie | 2008-12-11 |
* | | Qualify name of formattime() correctly | Simon McVittie | 2008-12-11 |
* | | Delay checking for session expiry til we actually post a comment | Simon McVittie | 2008-12-11 |
* | | comments: record the time at which each comment was posted | Simon McVittie | 2008-12-11 |
* | | comments: Use a checkconfig hook to get the default value of comments_pagename | Simon McVittie | 2008-12-11 |
* | | comments: render comments/commenturl in page.tmpl | Simon McVittie | 2008-12-11 |