| Commit message (Expand) | Author | Age |
|---|
| * | store state to avoid needing to rebuild when changing theme | Joey Hess | 2010-06-18 |
| * | needsbuild hook is passed an array ref | Joey Hess | 2010-06-18 |
| * | avoid shelling | Joey Hess | 2010-06-18 |
| * | mercurial: Fix buggy getctime code.•••The file passed to rcs_getctime is already absolute, and it was
trying to stick the srcdir on the front.
Also, eliminated potentially unsafe shelling.
| Joey Hess | 2010-06-18 |
| * | avoid dying if cannot chdir to an underlaydir | Joey Hess | 2010-06-17 |
| * | Merge branch 'themes' | Joey Hess | 2010-06-16 |
| |\ |
|
| | * | force rebuild for theme change•••For now, a rebuild is the only way to ensure the changed theme is used.
Ikiwiki normally will not realize style.css has changed, since themes
tend to have the same timestamp for the file.
| Joey Hess | 2010-06-16 |
| | * | add theme plugin | Joey Hess | 2010-06-16 |
| | * | Encode not used | Joey Hess | 2010-06-16 |
| * | | force list context•••run_or_die returns a status code in scalar context
| Joey Hess | 2010-06-16 |
| |/ |
|
| * | attachment: Support Windows paths when taking basename of client-supplied fil... | Joey Hess | 2010-06-16 |
| * | git: Gix --gettime to properly support utf8 filenames.•••In passing, fixed a bug where the srcdir was in a subdir of a repository
named "0".
| Joey Hess | 2010-06-15 |
| * | Make --gettime be honored after initial setup.•••Bugfix in passing: New files not treated as such when no rcs is used.
| Joey Hess | 2010-06-15 |
| * | fix other cases of unicode mixing issue•••and fix underlaydir override attack guard when srcdir is non-absolute
| Joey Hess | 2010-06-15 |
| |\ |
|
| | * | Fix issues with combining unicode srcdirs and source files.•••A short story:
Once there was a unicode string, let's call him Srcdir.
Along came a crufy old File::Find, who went through a tree and pasted each
of the leaves in turn onto Srcdir. But this 90's relic didn't decode the
leaves -- despite some of them using unicode! Poor Srcdir, with these
leaves stuck on him, tainted them with his nice unicode-ness. They didn't
look like leaves at all, but instead garbage.
(In other words, perl's unicode support sucks mightily, and drives
us all to drink and bad storytelling. But we knew that..)
So, srcdir is not normally flagged as unicode, because typically it's pure
ascii. And in that case, things work ok; File::Find finds filenames, which
are not yet decoded to unicode, and appends them to the srcdir, and then
decode_utf8 happily converts the whole thing.
But, if the srcdir does contain utf8 characters, that breaks. Or, if a Yaml
setup file is used, Yaml::Syck's implicitunicode sets the unicode flag of
*all* strings, even those containing only ascii. In either case, srcdir
has the unicode flag set; a non-decoded filename is appended, and the flag
remains set; and decode_utf8 sees the flag and does *nothing*. The result
is that the filename is not decoded, so looks valid and gets skipped.
File::Find only sticks the directory and filenames together in no_chdir
mode .. but we need that mode for security. In order to retain the
security, and avoid the problem, I made it not pass srcdir to File::Find.
Instead, chdir to the srcdir, and pass ".". Since "." is ascii, the problem
is avoided.
Note that chdir srcdir is safe because we check for symlinks in the srcdir
path.
Note that it takes care to chdir back to the starting location. Because
the user may have specified relative paths and so staying in the srcdir
might break. A relative path could even be specifed for an underlay dir, so
it chdirs back after each.
| Joey Hess | 2010-06-15 |
| * | | Fix issues with combining unicode srcdirs and source files.•••A short story:
Once there was a unicode string, let's call him Srcdir.
Along came a crufy old File::Find, who went through a tree and pasted each
of the leaves in turn onto Srcdir. But this 90's relic didn't decode the
leaves -- despite some of them using unicode! Poor Srcdir, with these
leaves stuck on him, tainted them with his nice unicode-ness. They didn't
look like leaves at all, but instead garbage.
In other words, perl's unicode support sucks mightily, and drives
us all to drink and bad storytelling. But we knew that..
So, srcdir is not normally flagged as unicode, because typically it's pure
ascii. And in that case, things work ok; File::Find finds filenames, which
are not yet decoded to unicode, and appends them to the srcdir, and then
decode_utf8 happily converts the whole thing.
But, if the srcdir does contain utf8 characters, that breaks. Or, if a Yaml
setup file is used, Yaml::Syck's implicitunicode sets the unicode flag of
*all* strings, even those containing only ascii. In either case, srcdir
has the unicode flag set; a non-decoded filename is appended, and
decode_utf8 sees the flag and does *nothing*. The result is that the
filename is not decoded, so looks valid and gets skipped.
File::Find only sticks the directory and filenames together in no_chdir
mode .. but we need that mode for security. In order to retain the
security, and avoid the problem, I made it not pass srcdir to File::Find.
Instead, chdir to the srcdir, and pass ".". Since "." is ascii, the problem
is avoided.
Note that it takes care to chdir back to the starting location. Because
the user may have specified relative paths and so staying in the srcdir
might break. A relative path could even be specifed for an underlay dir, so
it chdirs back after each.
| Joey Hess | 2010-06-15 |
| |/ |
|
| * | calendar: Tune archive_pagespec to only match pages, not other files. | Joey Hess | 2010-06-15 |
| * | editpage, comments: Fix broken links in sidebar (due to forcebaseurl). (Thank... | Joey Hess | 2010-06-14 |
| * | more symetric enable/disable•••Removing a plugin from add_plugins is not always enough to disable it.
It may have been redundantly added there and also pulled in via goodstuff.
Always add didabled plugins to disable_plugins.
| Joey Hess | 2010-06-13 |
| * | websetup: Allow enabling plugins listed in disable_plugins.•••The bug here was that disabling a plugin included thru goodstuff, like
htmlscrubber, caused it to be added to disable_plugins, and those plugins
were never loaded, so could not be re-enabled. Fix by allowing them to be
force loaded when appropriate. (Also that allows disabled plugins to still
record their setup options when dumping a setup file.)
| Joey Hess | 2010-06-13 |
| * | attachment: When inserting links, insert img directives for images, if that p... | Joey Hess | 2010-06-12 |
| * | avoid ugly warning if size="" is specified | Joey Hess | 2010-06-12 |
| * | edittemplate: Look for template pages under templates/ like everything else (... | Joey Hess | 2010-06-12 |
| * | edittemplate: Make silent mode not disable display when the template page doe... | Joey Hess | 2010-06-12 |
| * | editpage: Rename "comments" field to avoid CSS conflict with the comments div. | Joey Hess | 2010-06-12 |
| * | img: Support hspace and vspace attributes. | Joey Hess | 2010-06-12 |
| * | attachment: Show files from underlay in attachments list.•••While those files cannot be removed or renamed, this allows easy
downloading of them, and a new version can after all be uploaded.
| Joey Hess | 2010-06-12 |
| * | realm is an url pattern | Joey Hess | 2010-06-11 |
| * | openid: Add openid_realm and openid_cgiurl configuration options, useful in a... | Joey Hess | 2010-06-11 |
| * | calendar styling•••* calendar: Shorten day names, and improve styling of month calendar.
* style.css: Reduced sidebar width back to 20ex from 30; the month calendar
will now fit in the smaller width, and 30 was feeling too large.
| Joey Hess | 2010-06-10 |
| * | let's allow comments of "0" | Joey Hess | 2010-06-09 |
| * | editpage: Avoid storing accidental state changes when previewing pages.•••This is a slow, safe, stupid approach. Could make deep copies of the data
structures as backups instead of re-loading the index from disk.
| Joey Hess | 2010-06-09 |
| * | improve preview mode comments | Joey Hess | 2010-06-09 |
| * | Fix display of sidebar when previewing page edit. (Thanks, privat)•••On second thought, only display a page's personal sidebar when previewing
it, not when editing normally.
| Joey Hess | 2010-06-09 |
| * | relativedate: Fix problem with localised dates not working. | Joey Hess | 2010-06-09 |
| * | When editing a page, show that page's sidebar. (Thanks, privat) | Joey Hess | 2010-06-09 |
| * | img: Fill in missing height or width when scaling image. | Joey Hess | 2010-06-08 |
| * | fix uninitalized value warning | Joey Hess | 2010-05-21 |
| * | disable warnings when evaling setup files•••In particular, perl warns if a qw{} contains a #, but openids can.
If the setup file has 'use warnings', it will turn warning messages back
on, so it seems reasonable to squelch them by default.
| Joey Hess | 2010-05-21 |
| * | Fix a typo in the last release. | Joey Hess | 2010-05-18 |
| * | simplify example•••I've seen user(http://*) confuse someone who didn't know pagespecs to think
that just http://* would moderate all comments to every page, or something
like that.
| Joey Hess | 2010-05-18 |
| * | Fix a bug that prevented matching deleted comments, and so did not update pag...•••Problem is that by the time rendering calls render_dependent, %pagesources
has had deleted files removed from it. So match_comment's lookup of
files in there to see if they had the _comment extension failed.
I had to introduce a hash that temporarily holds filenames of deleted pages
to fix this.
Note that unlike comment(), internal() had avoided this pitfall by being
defined to match both internal and non-internal pages.
| Joey Hess | 2010-05-18 |
| * | force scalar context | Joey Hess | 2010-05-17 |
| * | fix typo | Joey Hess | 2010-05-15 |
| * | Revert "avoid showing comment post stuff on dynamic pages"•••This reverts commit 4a6d5330e5b9554f1bd25b9025dd96200c6519c7.
That was too ugly, the DYNAMIC test on page.tmpl will avoid the problem
anyway -- just needs to be added.
| Joey Hess | 2010-05-15 |
| * | avoid showing comment post stuff on dynamic pages•••If the site is configured to allow comments on *, then the comment post
interface was being added to cgi pages like signin and prefs. This fixes it
w/o requiring more page.tmpl changes. The pagetemplate hook is called by
misctemplate with an empty page name for dynamic pages.
| Joey Hess | 2010-05-15 |
| * | allow misctemplate callers to pass params to suppress actions etc•••Suppress disiplay of small search for on search results page, and of
Prefrences link on prefs page.
| Joey Hess | 2010-05-14 |
| * | avoid showing redundant search box on search results page | Joey Hess | 2010-05-14 |
| * | better misctemplate splitting sequence | Joey Hess | 2010-05-14 |
| * | put back recentchangesurl•••On second thought, misctemplate can use pagetemplate hooks to provide
it, so it's better to keep back-compat, and allow full customisation
of how it's displayed via the template.
| Joey Hess | 2010-05-14 |