| Commit message (Expand) | Author | Age |
* | editpage: Avoid inheriting internal page types. | Joey Hess | 2011-02-01 |
* | fix uninitilized value warning on bad page name•••properly this time
| Joey Hess | 2011-01-23 |
* | Revert "fix uninitilized value warning on bad page name"•••This reverts commit 5d3998555ffbeb1c20b84dd4cdc46c825c07bec8.
That broke posting via blog form.
| Joey Hess | 2011-01-23 |
* | fix uninitilized value warning on bad page name | Joey Hess | 2011-01-22 |
* | add cgitemplate•••cgitemplate is a modified misctemplate that takes an optional cgi object
and uses it to set the baseurl, and also optionally the forcebaseurl,
if a page is provided.
If no cgi object is provided, it will fall back to using $config{url}.
I expect this will only be needed in exceptional cases where
that doesn't much matter, such as cgierror().
showform uses cgitemplate, so there is no more need for showform_preview.
| Joey Hess | 2011-01-05 |
* | Fix base url when previewing. Was broken by urlto changes in last release.•••Added a showform_preview that is like showform, but sets forcebaseurl
to point to the page being previewed.
| Joey Hess | 2011-01-05 |
* | editpage, comment: Clean up title when editing or creating a page or comment.•••Now that page.tmpl is used for cgi, the parentlinks are able to be
displayed even when creating or editing a page. So it's redundant to
include the path to the page in the title, remove it.
| Joey Hess | 2010-12-25 |
* | use one-parameter form of urlto | Joey Hess | 2010-11-29 |
* | Use local paths for most references to pages | Simon McVittie | 2010-11-23 |
* | Use local paths for the CGI URL | Simon McVittie | 2010-11-23 |
* | Use local paths for redirection where possible | Simon McVittie | 2010-11-23 |
* | rcs_commit and rcs_commit_staged api changes•••Using named parameters for these is overdue. Passing the session in a
parameter instead of passing username and IP separately will later allow
storing other session info, like username or part of the email.
Note that these functions are not part of the exported API,
and the prototype change will catch (most) skew, so I am not changing
API versions. Any third-party plugins that call them will need updated
though.
| Joey Hess | 2010-06-23 |
* | stop using REMOTE_ADDR•••Everywhere that REMOTE_ADDR was used, a session object is available, so
instead use its remote_addr method.
In IkiWiki::Receive, stop setting a dummy REMOTE_ADDR.
Note that it's possible for a session cookie to be obtained using one IP
address, and then used from another IP. In this case, the first IP will now
be used. I think that should be ok.
| Joey Hess | 2010-06-23 |
* | editpage, comments: Fix broken links in sidebar (due to forcebaseurl). (Thank... | Joey Hess | 2010-06-14 |
* | editpage: Rename "comments" field to avoid CSS conflict with the comments div. | Joey Hess | 2010-06-12 |
* | editpage: Avoid storing accidental state changes when previewing pages.•••This is a slow, safe, stupid approach. Could make deep copies of the data
structures as backups instead of re-loading the index from disk.
| Joey Hess | 2010-06-09 |
* | Fix display of sidebar when previewing page edit. (Thanks, privat)•••On second thought, only display a page's personal sidebar when previewing
it, not when editing normally.
| Joey Hess | 2010-06-09 |
* | When editing a page, show that page's sidebar. (Thanks, privat) | Joey Hess | 2010-06-09 |
* | remove unused indexlink function and template variable | Joey Hess | 2010-05-05 |
* | template() - return params in list context•••I forgot CGI::Formbuilder's horrible interface that needs template
parameters instead of a constructed object.
| Joey Hess | 2010-04-24 |
* | look for templates in srcdir and underlays, first•••This entailed changing template_params; it no longer takes the template
filename as its first parameter.
Add template_depends to api and replace calls to template() with
template_depends() in appropriate places, where a dependency should be
added on the template.
Other plugins don't use template(), so will need further work.
Also, includes are disabled for security. Enabling includes only when using
templates from the templatedir would be nice, but would add a lot of
complexity to the implementation.
| Joey Hess | 2010-04-22 |
* | typo | Joey Hess | 2010-04-20 |
* | remove explicit absolute test•••file_pruned now tests for that
| Joey Hess | 2010-04-20 |
* | clarify why absolute is tested & stripped here•••file_prune also fails on absolute filenames now
| Joey Hess | 2010-04-20 |
* | unfinished file_prune revamp•••Many calls to file_prune were incorrectly calling it with 2 parameters.
In cases where the filename being checked is relative to the srcdir,
that is not needed.
Made absolute filenames be pruned. (This won't work for the 2 parameter call
style.)
| Joey Hess | 2010-04-17 |
* | Group related plugins into sections in the setup file, and drop unused rcs pl... | Joey Hess | 2010-02-11 |
* | reorder canedit checks during page creation to have best_loc first•••When creating a page, multiple locations are tested to see if they can be
edited. If all fail, one of the failure subs is called, to log the user in
to allow them to proceed with the edit. So far so good.
But, what if some pages fail for one reason, and some for another? This
occurs when httpauth_pagespec is used in conjunction with signinedit (and
openid or something). When the user is not signed in at all
The former will fail to edit a page because the user was not httpauthed.
The latter will fail to edit a different page, because the user was not
signed in. One of their failure methods gets to run first.
The page creation code always ran the failure method corresponding to the
topmost page location. So, when editing a foo/Discussion page, and with
httpauth_pagespec => "*!/Discussion", it ran the httpauth failure method,
which was exactly the wrong thing to do.
I fixed this by making it instead run the failure method for the *best*
page location. In the above example, that's foo/Discussion, so signinedit
runs, as desired, and we get the signin page.
This seems like it will be the right choice, or at least an acceptable
choice. If a user wants to use httpauth they can always choose it on the
signin page.
| Joey Hess | 2010-02-11 |
* | factor out a userpage function•••Not yet exported, as only 4 quite core plugins use it.
| Joey Hess | 2010-02-04 |
* | Add discussionpage configuration setting•••By adding this setting, we get both more configurability, and a minor
optimisation too, since gettext does not need to be called continually
to get the Discussion value.
| Joey Hess | 2009-08-13 |
* | fix further places where translated discussion case was assumed•••Another benefit is that consistently using gettext("Discussion")
eliminates the need to translate one string.
| Joey Hess | 2009-06-04 |
* | support longname for page types in commands and rename•••Also, sort the list of page types.
| Joey Hess | 2009-05-21 |
* | tidy up new page_types code | Jon Dowland | 2009-05-16 |
* | check for longname for each syntax plugin•••We build an array of [ plugin name, long name ] pairs, where long name
is an optional argument to hook(). So, a syntax plugin could define
long "friendly" name, such as "Markdown" instead of mdwn, and we would
then pass this array to formbuilder to populate the drop-down on the
edit page.
| Jon Dowland | 2009-05-16 |
* | move check_canedit, check_content to IkiWiki library from editpage•••It no longer makes sense to keep these functions in editpage, because
serveral plugins now exist that use them, and users may want to disable
editpage, while leaving those plugins enabled.
Most notably, comments uses both functions, and it's entirely appropriate
to disable editpage but still want to have comments enabled.
Less likely, attachments, rename, and remove all use check_canedit -- but
it would be unusual indeed to want to use these w/o editpage.
| Joey Hess | 2009-02-12 |
* | comments: If comment content checks fail, store the comment (in .ikiwiki/comm... | Joey Hess | 2009-01-25 |
* | checkcontent: New hook, can be used to implement arbitrary content filters, i... | Joey Hess | 2009-01-16 |
* | remove cruft•••wtf does it do? absolutely nothing
| Joey Hess | 2008-12-19 |
* | Coding style change: Remove explcit vim folding markers. | Joey Hess | 2008-12-17 |
* | checksessionexpiry: rework•••This function as factored out was a bit confusing, I think this makes more
sense.
| Joey Hess | 2008-12-17 |
* | editpage: factor out checksessionexpiry into IkiWiki::CGI | Simon McVittie | 2008-12-11 |
* | more work on untrusted committers•••Wired up check_canedit and check_canremove, still need to deal with
check_canattach, and test.
| Joey Hess | 2008-10-23 |
* | don't special case preview•••Whenever the edit form is submitted, but not saved, the page location
select should reduce to the currently selected value. This was only done
when previewing before, but is also needed in order to support the case of
adding an attachment to a page that is just being created.
Before this change, the attachment plugin would get a weird value in
$form->field("page"), that did not reflect the actual page location.
| Joey Hess | 2008-10-02 |
* | use newpagefile | Joey Hess | 2008-09-29 |
* | support indexpages when creating new pages•••Initial draft, may need to factor new page filename code out into helper
function if other plugins need to do the same..
| Joey Hess | 2008-09-29 |
* | fix handing of case of file first created by preview but then saved•••To handle this, avoid populating %renderedfiles in preview,
and in expiry, check if the file is in %renderedfiles, if it is
do not delete it since it was saved.
| Joey Hess | 2008-09-29 |
* | editpage: Be more aggressive (and less buggy) about cleaning up temporary fil... | Joey Hess | 2008-09-27 |
* | Merge commit 'smcv/beautify'•••Conflicts:
IkiWiki/Plugin/recentchanges.pm
Note that smcv's approach of using urlto also gets the url right when
redirecting to a non-html file, which is a better approach than my recent
fix to recentchanges
| Joey Hess | 2008-09-27 |
|\ |
|
| * | editpage: beautify redirection URLs, avoiding exposing the implementation det... | Simon McVittie | 2008-09-21 |
* | | add missing page name sanity check | Joey Hess | 2008-09-20 |
|/ |
|
* | editpage: New core plugin factoring out page editing to allow disabling it if... | Joey Hess | 2008-09-05 |