| Commit message (Expand) | Author | Age |
|---|
| * | HTML-encode meta title, description, guid on output, but not in the pagestate•••This makes them consistent with the rest of the meta keys. A wiki rebuild
will be needed on upgrade to this version; until the wiki is rebuilt,
double-escaping will occur in the titles of pages that have not changed.
| Simon McVittie | 2010-04-06 |
| * | comments: Fix missing entity encoding in title.•••The meta title data set by comments needs to be encoded the same way that
meta encodes it. (NB The security implications of the missing encoding
are small.)
Note that meta's encoding of title, description, and guid data, and not
other data, is probably a special case that should be removed. Instead,
these values should be encoded when used. I have avoided doing so here
because that would mean forcing a wiki rebuild on upgrade to have the data
consitently encoded.
| Joey Hess | 2010-04-05 |
| * | typo | Joey Hess | 2010-03-12 |
| * | typo | Joey Hess | 2010-03-09 |
| * | Fix utf8 issues in calls to md5_hex.•••This prevented comments containing some utf-8, including euro sign, from
being submitted. Since md5_hex is a C implementation, the string has to be
converted from perl's internal encoding to utf-8 when it is called. Some
utf-8 happened to work before, apparently by accident.
Note that this will change the checksums returned.
unique_comment_location is only used when posting comments, so the checksum
does not need to be stable there.
I only changed page_to_id for completeness; it is passed a comment page
name, and they can currently never contain utf-8.
In teximg, the bug could perhaps be triggered if the tex source contained
utf-8. If that happens, the checksum will change, and some extra work might
be performed on upgrade to rebuild the image.
| Joey Hess | 2010-03-09 |
| * | comments: Display number of comments in comment action link.•••This was not doable before, but when I added transitive dependency handling
in the big dependency rewrite, it became possible to include a comment
count when inlining.
This also improves the action link when a page has no comments. It will
link direct to the cgi to allow posting the first comment. And if the page
is locked to prevent posting new comments, the link is no longer shown.
| Joey Hess | 2010-02-14 |
| * | minor refactor/optimisation | Joey Hess | 2010-02-14 |
| * | add section information | Joey Hess | 2010-02-12 |
| * | factor out a userpage function•••Not yet exported, as only 4 quite core plugins use it.
| Joey Hess | 2010-02-04 |
| * | comments: Fix permalinks for comments using new conflict-free filenames. | Joey Hess | 2010-01-04 |
| * | comments: Add a checksum to the name of comment pages, to avoid merge conflic... | Joey Hess | 2009-12-30 |
| * | comment: Make comment directives no longer use the internal "_comment" form, ...•••Rationalle: Comments need to be user-editable so that they can be posted
via git commit etc.
The _comment directive is still supported, for back-compat.
| Joey Hess | 2009-06-02 |
| * | support longname for page types in commands and rename•••Also, sort the list of page types.
| Joey Hess | 2009-05-21 |
| * | comments: Add link to comment post form to allow user to sign in if they wish... | Joey Hess | 2009-04-23 |
| * | use md5sum for page_to_id•••The munged ids were looking pretty nasty, and were not completly guaranteed
to be unique. So a md5sum seems like a better approach. (Would have used
sha1, but md5 is in perl core.)
| Joey Hess | 2009-03-27 |
| * | comments: Fix anchor ids to be legal xhtml. Closes: #521339•••Well, that was a PITA.
Luckily, this doesn't break guids to comments in rss feeds,
though it does change the links.
I haven't put in a warning about needing to rebuild to get
this fix. It's probably good enough for new comments to get the
fix, without a lot of mass rebuilding.
| Joey Hess | 2009-03-26 |
| * | comments: Fix too loose test for comments pages that matched normal pages wit... | Joey Hess | 2009-03-26 |
| * | comments: Avoid showing comment moderation button in prefs to non-admins. | Joey Hess | 2009-02-26 |
| * | Split cgi_goto into a goto plugin | Simon McVittie | 2009-01-31 |
| * | comments: delete cgi hook in favour of the global one | Simon McVittie | 2009-01-31 |
| * | typo | Joey Hess | 2009-01-26 |
| * | format moderation queue only at end, avoid O(N^3) bug•••It was calling format hooks for each comment on the page.
When relativedate is enabled, that made it insert <script> tags
for each comment. And the browser loaded the same script over and over,
which was slow on its own. But that was nothing compared to running
the onload even over and over.. especially since the hook system
added a new call to the hook each time it loaded.
For a page with 10 comments, that caused the relativedate DOM parsing
code to run 1000 times, I think. Anyway, it was sloow. Now it runs once.
| Joey Hess | 2009-01-25 |
| * | add reject all marked defer checkbox | Joey Hess | 2009-01-25 |
| * | sort comment queue by time, newest first | Joey Hess | 2009-01-25 |
| * | add a button to prefs page for comment moderation | Joey Hess | 2009-01-25 |
| * | clean up comment preview•••Remove actions from it, and avoid a broken title link.
| Joey Hess | 2009-01-25 |
| * | comments: Add a moderation web interface. | Joey Hess | 2009-01-25 |
| * | comments: If comment content checks fail, store the comment (in .ikiwiki/comm... | Joey Hess | 2009-01-25 |
| * | fix uninitialized value warnings•••I suspect these are only triggered by spammers.
| Joey Hess | 2009-01-22 |
| * | make postcomment() pagespecs work while in checkcontent | Joey Hess | 2009-01-16 |
| * | checkcontent: New hook, can be used to implement arbitrary content filters, i... | Joey Hess | 2009-01-16 |
| * | remove xxx comment•••IIRC I analised this and the code is right
| Joey Hess | 2009-01-16 |
| * | comments: if the remove plugin is enabled, append a "Remove comment" link | Simon McVittie | 2009-01-10 |
| * | comments: only try to insert commentuser etc. into templates if the page cont... | Simon McVittie | 2009-01-10 |
| * | comments: Fix cache avoidance hack.•••The ?updated needs to come before the #anchor or browsers will not follow
the anchor.
| Joey Hess | 2009-01-07 |
| * | comments: Add cache avoidance.•••This got lost when we added the jump-to-comment anchor.
| Joey Hess | 2008-12-28 |
| * | Merge branch 'master' into next | Joey Hess | 2008-12-26 |
| |\ |
|
| | * | comments: Deal with users entering unqualified or partial urls.•••People seem to be able to expect to enter www.foo.com and get away with it.
The resulting my.wiki/www.foo.com link was not ideal.
To fix it, use URI::Heuristic to expand such things into a real url. It
even looks up hostnames in the DNS if necessary.
| Joey Hess | 2008-12-26 |
| * | | finalise version 3.00 of the plugin api | Joey Hess | 2008-12-23 |
| |/ |
|
| * | comments: substitute commentsurl and atomcommentsurl for use in feeds | Simon McVittie | 2008-12-21 |
| * | comments: run pagetemplate hooks•••This fixes the bug that comments are always said to be from an anonymous
user at an unknown IP address.
| Simon McVittie | 2008-12-21 |
| * | comments: linkify and preprocess preview with correct 'page' param | Simon McVittie | 2008-12-21 |
| * | avoid storing transient state in pagestate•••None of the comment state needs to be stored through the a later run of
ikiwiki, so move it all from pagestate to a more transient storage.
This is assuming that we'll never want to add pagespecs to search against
the comment state. Pagespecs like author() are why the meta plugin does
store its meta data in pagestate -- the data can be needed later to match
against.
| Joey Hess | 2008-12-20 |
| * | comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTA...•••Also refactor page.tmpl to use if/else rather than unless/if.
| Simon McVittie | 2008-12-20 |
| * | comments: pass COMMENTOPENID to templates | Simon McVittie | 2008-12-20 |
| * | comments: remove linkuser(), it's been integrated into preprocess() now | Simon McVittie | 2008-12-20 |
| * | _comment directive: if the user looks like an OpenID, store that | Simon McVittie | 2008-12-20 |
| * | fix comment permalink to always point to comment parent page | Joey Hess | 2008-12-19 |
| * | remove cruft•••wtf does it do? absolutely nothing
| Joey Hess | 2008-12-19 |
| * | rename comments_form to editcomment | Joey Hess | 2008-12-19 |