diff options
Diffstat (limited to 'doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn')
| -rw-r--r-- | doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn | 22 |
1 files changed, 2 insertions, 20 deletions
diff --git a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn index f2e3849f4..712205b7a 100644 --- a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn +++ b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn @@ -14,26 +14,8 @@ My guess is this sits somewhere here: Yet I am not sure how to fix that kind of problem in Perl... --[[anarcat]] -I tried to make this unit test: - -[[!format perl """ -#!/usr/bin/perl -use warnings; -use strict; -use Test::More tests => 5; - -BEGIN { use_ok("IkiWiki"); } - -$IkiWiki::config{verbose} = 1; -$IkiWiki::config{syslog} = 1; -$IkiWiki::config{wikiname} = 'ascii'; -ok(debug('test')); -$IkiWiki::config{wikiname} = 'not â’¶SCII'; -ok(debug('test')); -"""]] - -And I couldn't reproduce the problem. Therefore, I suspect the problem may be somewhere else - maybe in the options parsing? One thing that's for sure: when I put that funky character in the title, it breaks logging! If I remove the "eval" above, I get: +If I remove the "eval" above, I get: Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485. -I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. +I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working [[!taglink patch]] for the bug, again in git. |