diff options
Diffstat (limited to 'doc/bugs/htmlscrubber_undoes_email_obfuscation_by_Text::Markdown.mdwn')
| -rw-r--r-- | doc/bugs/htmlscrubber_undoes_email_obfuscation_by_Text::Markdown.mdwn | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/doc/bugs/htmlscrubber_undoes_email_obfuscation_by_Text::Markdown.mdwn b/doc/bugs/htmlscrubber_undoes_email_obfuscation_by_Text::Markdown.mdwn new file mode 100644 index 000000000..12018d517 --- /dev/null +++ b/doc/bugs/htmlscrubber_undoes_email_obfuscation_by_Text::Markdown.mdwn @@ -0,0 +1,37 @@ +From the source of [[usage]]: + + <a href="mailto:joey@ikiwiki.info">joey@ikiwiki.info</a> + +Text::Markdown obfuscates email addresses in the href= attribute and in the text. +Apparently this can't be configured. + +HTML::Scrubber doesn't set `attr_encoded` for its HTML::Parser, so the href= attribtute is decoded. +Currently it seems it doesn't set `attr_encoded` for good reason: so attributes can be sanitized easily, +e.g. as in htmlscrubber with `$safe_url_regexp`. +This apparently can't be configured either. + +So I can't see an obvious solution to this. +Perhaps improvements to Text::Markdown or HTML::Scrubber can allow a fix. + +One question is: how useful is email obfuscation? +Don't spammers use HTML parsers? + +> I now see this was noted in the formatting [[/ikiwiki/formatting/discussion]], and won't/can't be fixed. +> So I guess this is [[done]]. --Gabriel + +I've [[patch]]ed mdwn.pm to prevent Text::Markdown from obfuscating the emails. +The relevant commits are on the master branch of [my "fork" of ikiwiki on Github] [github]: + +- 7d0970adbcf0b63e7e5532c239156f6967d10158 +- 52c241e723ced4d7c6a702dd08cda37feee75531 + +--Gabriel. + +[github]: http://github.com/gmcmanus/ikiwiki/ + +> Thanks for coming up with a patch, but overriding +> `Text::Markdown::_EncodeEmailAddress` gets into its internals more than +> I'm comfortable with. +> +> It would probably be best to add an option to [[!cpan Text::Markdown]] to +> let the email address munging be disabled. --[[Joey]] |