aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn19
1 files changed, 19 insertions, 0 deletions
diff --git a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
index 59fe1e6fb..9f968b525 100644
--- a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
+++ b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
@@ -56,4 +56,23 @@ sub formbuilder_setup (@) {
I believe this could be worked around simply by re-enabling that field and allowing the user to specify an email there by hand, making a note that the OpenID provider's email is used by default.
+Here's the dumbest [[!taglink patch]] that actually fixes the problem for me:
+
+[[!format diff """
+diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm
+index e3b9982..df87ba3 100644
+--- a/IkiWiki/Plugin/openid.pm
++++ b/IkiWiki/Plugin/openid.pm
+@@ -104,7 +104,6 @@ sub formbuilder_setup (@) {
+ size => 1, force => 1,
+ fieldset => "login",
+ comment => $session->param("name"));
+- $form->field(name => "email", type => "hidden");
+ }
+ }
+
+"""]]
+
+It would probably be better to add a comment on the field as indicated above, but it's a good proof of concept.
+
Any other ideas?