diff options
| author | https://shinji.startssl.com/ <https://shinji.startssl.com/@web> | 2013-01-28 04:35:28 -0400 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2013-01-28 04:35:28 -0400 |
| commit | 56b610277fdf81b3de4c3f2e396bddf3bb338f85 (patch) | |
| tree | c23c8fd3719c2e6eed60be41833eb78dcff39a7f /doc | |
| parent | b67e81cb131fc32dcc0a519c5da4a76b4da978d7 (diff) | |
| download | ikiwiki-56b610277fdf81b3de4c3f2e396bddf3bb338f85.tar ikiwiki-56b610277fdf81b3de4c3f2e396bddf3bb338f85.tar.gz | |
Create new bug with patch
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/bugs/recentchanges_sets_has__95__diffurl__61__1_when_diffurl_is_empty.mdwn | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/bugs/recentchanges_sets_has__95__diffurl__61__1_when_diffurl_is_empty.mdwn b/doc/bugs/recentchanges_sets_has__95__diffurl__61__1_when_diffurl_is_empty.mdwn new file mode 100644 index 000000000..d0297bb3e --- /dev/null +++ b/doc/bugs/recentchanges_sets_has__95__diffurl__61__1_when_diffurl_is_empty.mdwn @@ -0,0 +1,16 @@ +recentchanges.pm sets the template variable HAS_DIFFURL to 1 based solely on whether or not diffurl is defined. I found that diffurl was defined, but empty. The recentchanges template depends on this for recentchangesdiff to properly function -- diff toggling is dependent on HAS_DIFFURL evaluating to false. Adding a check for a non-zero length diffurl fixed the issue for me. A patch against ikiwiki-3.20121212 is as follows: + + --- a/IkiWiki/Plugin/recentchanges.pm 2013-01-27 20:08:59.000000000 -0800 + +++ b/IkiWiki/Plugin/recentchanges.pm 2013-01-27 20:08:30.000000000 -0800 + @@ -181,7 +181,8 @@ sub store ($$$) { + else { + $_->{link} = pagetitle($_->{page}); + } + - if (defined $_->{diffurl}) { + + if (defined $_->{diffurl} && + + length($_->{diffurl}) > 0) { + $has_diffurl=1; + } + + +(There should be one more line at the bottom with a single space on it...) |