diff options
| author | Joey Hess <joey@kitenet.net> | 2011-07-19 11:56:52 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2011-07-19 11:57:50 -0400 |
| commit | 7fa76ee9d3f04605294f1b6cd54111253ffedcf2 (patch) | |
| tree | ffe1ad645b81aa33c74822bd2bbcdde7f935f41b /doc/todo | |
| parent | b37c622355bc1591e8df65dd3581d68b569b3e38 (diff) | |
| download | ikiwiki-7fa76ee9d3f04605294f1b6cd54111253ffedcf2.tar ikiwiki-7fa76ee9d3f04605294f1b6cd54111253ffedcf2.tar.gz | |
response
Diffstat (limited to 'doc/todo')
| -rw-r--r-- | doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn | 9 | ||||
| -rw-r--r-- | doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn | 10 |
2 files changed, 19 insertions, 0 deletions
diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn index 0e9d61398..c7438feb6 100644 --- a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn +++ b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn @@ -4,6 +4,15 @@ I modeled the message on `rename.pm`, which used a lowercase initial letter and Diff follows. --[[Daniel Andersson]] +> This is somewhat intentional. It's pretty usual for changes to be made +> to a wiki without bothering to say what changed; the change speaks for +> itself and it would just be clutter to mention what file was changed, +> since any reasonable interface will show the filename, or a link, +> or some summary of what files were affected when showing a change. +> +> Also your patch stomps over any commit message that the user *does* +> provide, so certianly cannot be applied as-is. --[[Joey]] + [[!tag patch]] --- diff --git a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn index f000878b7..8b1dd74a7 100644 --- a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn +++ b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn @@ -2,6 +2,16 @@ As [[Add instructive commit messages for add _47_ edit pages]], but for `remove. I use a `join()` since it at least looks like the plugin is able to remove several pages at once (`foreach` looping over file parameters), thus holding multiple entries in `@pages`. I haven't seen this happen, though. +> I feel that anything that shows a change should show what files were +> changed (at least as an easily accessible option), so mentioning +> filenames in commits is almost always clutter. +> +> It could be argued that there should be no message at all here, unless +> the user provides one (which they currently cannot), as is done when +> adding files. But the entire removal of a page from a wiki is a fairly +> unusual circumstance that is probably best highlighted as such in +> recentchanges. --[[Joey]] + Diff follows. --[[Daniel Andersson]] [[!tag patch]] |