aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/bestlink_change_update_issue.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-10-05 22:30:14 -0400
committerJoey Hess <joey@gnu.kitenet.net>2009-10-05 22:30:14 -0400
commit534518792d95fb51f6d49c0c48f3f8b3b7398df3 (patch)
tree542be42325a604a0e1bf975b43ebb7552ff4f6c9 /doc/bugs/bestlink_change_update_issue.mdwn
parentfd7b5767d3d377185838895d04f51288f0889a59 (diff)
downloadikiwiki-534518792d95fb51f6d49c0c48f3f8b3b7398df3.tar
ikiwiki-534518792d95fb51f6d49c0c48f3f8b3b7398df3.tar.gz
update
Diffstat (limited to 'doc/bugs/bestlink_change_update_issue.mdwn')
-rw-r--r--doc/bugs/bestlink_change_update_issue.mdwn26
1 files changed, 20 insertions, 6 deletions
diff --git a/doc/bugs/bestlink_change_update_issue.mdwn b/doc/bugs/bestlink_change_update_issue.mdwn
index 211a78332..8a526e821 100644
--- a/doc/bugs/bestlink_change_update_issue.mdwn
+++ b/doc/bugs/bestlink_change_update_issue.mdwn
@@ -3,13 +3,27 @@
Foo/Baz, and Foo/Bar/Baz gets added, it will update the links in Foo/Bar
to point to it, but will forget to update the backlinks in Foo/Baz.
+ The buggy code is in `refresh()`, when it determines what
+ links, on what pages, have changed. It only looks at
+ changed/added/deleted pages when doing this. But when Foo/Bar/Baz
+ is added, Foo/Bar is not changed -- so the change it its
+ backlinks is not noticed.
+
+ To fix this, it needs to consider, when rebuilding Foo/Bar for the changed
+ links, what oldlinks Foo/Bar had. If one of the oldlinks linked to
+ Foo/Baz, and not links to Foo/Bar/Baz, it could then rebuild Foo/Baz.
+
+ Problem is that in order to do that, it needs to be able to tell that
+ the oldlinks linked to Foo/Baz. Which would mean either calculating
+ all links before the scan phase, or keeping a copy of the backlinks
+ from the last build, and using that. The first option would be a lot
+ of work for this minor issue.. it might be less expensive to just rebuild
+ *all* pages that Foo/Bar links to.
+
+ Keeping a copy of the backlinks has some merit. It could also be
+ incrementally updated.
+
* And if Foo/Bar/Baz is then removed, Foo/Bar gets a broken link,
instead of changing back to linking to Foo/Baz.
This old bug still exists as of 031d1bf5046ab77c796477a19967e7c0c512c417.
-and now this same problem also affects link dependencies.
-
-(Some of) The buggy code is in `find_changed_links`
-which doesn't detect that the link has changed in
-this case, because when it looks at where the `%oldlinks` link to,
-it does so after having updated state to add/remove the page.