diff options
| author | https://id.koumbit.net/anarcat <https://id.koumbit.net/anarcat@web> | 2013-09-06 17:51:38 -0400 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2013-09-06 17:51:38 -0400 |
| commit | b1b60e75982bf3b9c7b9fa27a6baddb4ba96d318 (patch) | |
| tree | ca782ff34f8a50e83918a59cdf5a8fd37b22f0d5 | |
| parent | cc684c4d984524f07f8ca7cb19c5e8dc5a5d5c14 (diff) | |
| download | ikiwiki-b1b60e75982bf3b9c7b9fa27a6baddb4ba96d318.tar ikiwiki-b1b60e75982bf3b9c7b9fa27a6baddb4ba96d318.tar.gz | |
and here's a patch
| -rw-r--r-- | doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn index 59fe1e6fb..9f968b525 100644 --- a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn +++ b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn @@ -56,4 +56,23 @@ sub formbuilder_setup (@) { I believe this could be worked around simply by re-enabling that field and allowing the user to specify an email there by hand, making a note that the OpenID provider's email is used by default. +Here's the dumbest [[!taglink patch]] that actually fixes the problem for me: + +[[!format diff """ +diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm +index e3b9982..df87ba3 100644 +--- a/IkiWiki/Plugin/openid.pm ++++ b/IkiWiki/Plugin/openid.pm +@@ -104,7 +104,6 @@ sub formbuilder_setup (@) { + size => 1, force => 1, + fieldset => "login", + comment => $session->param("name")); +- $form->field(name => "email", type => "hidden"); + } + } + +"""]] + +It would probably be better to add a comment on the field as indicated above, but it's a good proof of concept. + Any other ideas? |