aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2011-07-19 12:28:34 -0400
committerJoey Hess <joey@kitenet.net>2011-07-19 12:28:34 -0400
commit7a1ab785f8563a9f94378810bf3c6a97c5ccde11 (patch)
tree07a40adfce4d8ff87a9d9fe4fb51d0ba42a35052
parent758a4c23fd0fc30b89739f0d2be7bf0fe2f81be8 (diff)
downloadikiwiki-7a1ab785f8563a9f94378810bf3c6a97c5ccde11.tar
ikiwiki-7a1ab785f8563a9f94378810bf3c6a97c5ccde11.tar.gz
response
-rw-r--r--doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn6
1 files changed, 6 insertions, 0 deletions
diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
index 571e1a6eb..cfb5b98a3 100644
--- a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
+++ b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
@@ -12,6 +12,12 @@ Diff follows. --[[Daniel Andersson]]
>> I use the Mercurial backend, and Mercurial doesn't allow empty commit messages, so if there were no message, it would default to "no message given" (hardcoded in `mercurial.pm`), which is also clutter, and non-descriptive at that. But I'm on board with your reasoning. It's a matter of taste (and somewhat backend), I guess. I might continue to locally use this patch (with the caveat below fixed when commit message is given), but I won't push for it to be included upstream. --[[Daniel Andersson]]
+>>> Hmm.. It would be possible to make the mercurial backend
+>>> include the filename (or just "added" or "edited") in the commit
+>>> message. It might take some work, especially to handle
+>>> `rcs_commit_staged`, since it would probably need to cache
+>>> what files have been staged for commit. --[[Joey]]
+
> Also your patch stomps over any commit message that the user *does*
> provide, so certianly cannot be applied as-is. --[[Joey]]