diff options
author | chrysn <chrysn@fsfe.org> | 2014-07-05 19:11:47 +0200 |
---|---|---|
committer | chrysn <chrysn@fsfe.org> | 2014-07-05 19:11:47 +0200 |
commit | 875f1e50cbc7c9b5ee7153747b4c92750eef10cf (patch) | |
tree | 8c06d544933044949fbae1ca21f598204ed53246 | |
parent | 996eedc3ba03ce48e234914803da42c66c5be3d9 (diff) | |
download | ikiwiki-875f1e50cbc7c9b5ee7153747b4c92750eef10cf.tar ikiwiki-875f1e50cbc7c9b5ee7153747b4c92750eef10cf.tar.gz |
comments on templatebody and phases
-rw-r--r-- | doc/bugs/template_creation_error.mdwn | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/bugs/template_creation_error.mdwn b/doc/bugs/template_creation_error.mdwn index 98d1cf235..d3c0bcca5 100644 --- a/doc/bugs/template_creation_error.mdwn +++ b/doc/bugs/template_creation_error.mdwn @@ -255,3 +255,10 @@ same logic as IkiWiki itself. I don't think that's serious. --[[smcv]] >>> is a start towards that; the docwiki builds successfully, but >>> the tests that use IkiWiki internals also need updating to >>> set `$phase = PHASE_RENDER` before they start preprocessing. --s + +>>>> reviewing those modifications, i think this is a good way to go. along +>>>> with warning about pagespecs evaluated in scan phase, i think it should be +>>>> an error to invoke scan in the render phase; that would mean that +>>>> `readtemplate` needs to check whether it's invoked as a scan or not to +>>>> decide whether to scan the template page, but would be generally more +>>>> robust for future plugin writing. --[[chrysn]] |