diff options
| author | smcv <smcv@web> | 2014-07-03 17:49:02 -0400 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2014-07-03 17:49:02 -0400 |
| commit | 6d90e56c8dbb1e380f0e621305fd014767e9364b (patch) | |
| tree | 66e0beea5823958db9db238850899a360bb28803 | |
| parent | 03ee0fd9f717f24c86a5f1c642c3fb4a2a278d96 (diff) | |
| download | ikiwiki-6d90e56c8dbb1e380f0e621305fd014767e9364b.tar ikiwiki-6d90e56c8dbb1e380f0e621305fd014767e9364b.tar.gz | |
remove patch tag, the patch here was merged
| -rw-r--r-- | doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn index b641f2db2..0d40d232a 100644 --- a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn +++ b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn @@ -18,10 +18,15 @@ Yet I am not sure how to fix that kind of problem in Perl... --[[anarcat]] > > Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485. > -> I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working [[!taglink patch]] for the bug, again in git. +> I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working patch for the bug, again in git. > > > One last note: I noticed that this problem also happens elsewhere in ikiwiki. For example, the [[plugins/notifyemail]] plugin will silently fail to send notifications if the pages contain unicode. The [[plugins/notifychanges]] plugin I am working on (in [[todo/option to send only the diff in notifyemail]]) seems to be working around the issue so far, but there's no telling which similar problem are out there. ->> [[I'd merge it|/users/smcv/yesplease]]. --[[smcv]] +>> I'd merge it. --[[smcv]] >>> I've merged it, but I don't feel it fixes this bug. --[[Joey]] + +>>>> (I removed the patch tag to take it off the patches list.) +>>>> +>>>> What else is needed? Systematic classification of outputs into +>>>> those that do and don't cope with Unicode? --[[smcv]] |