aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-01-14 04:30:53 +0000
committerjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-01-14 04:30:53 +0000
commitc4b171221279d358b1aee1468e7d8d98b923af8c (patch)
treefd906816dabf7b6e95259865106f2243a1d4525c
parentd253cef179bbe1c268a9b4bbf5f08324915b46e3 (diff)
downloadikiwiki-c4b171221279d358b1aee1468e7d8d98b923af8c.tar
ikiwiki-c4b171221279d358b1aee1468e7d8d98b923af8c.tar.gz
* Change the RecentChanges page to show the path of changed pages.
-rw-r--r--IkiWiki/CGI.pm2
-rw-r--r--debian/changelog3
-rw-r--r--doc/index/discussion.mdwn16
-rw-r--r--doc/patchqueue/full_paths_in_recentchanges.mdwn15
4 files changed, 4 insertions, 32 deletions
diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index 71a3299a4..96b9dab61 100644
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -92,7 +92,7 @@ sub cgi_recentchanges ($) { #{{{
delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
$change->{pages} = [
map {
- $_->{link} = htmllink("", "", $_->{page}, 1);
+ $_->{link} = htmllink("", "", $_->{page}, 1, 0, pagetitle($_->{page}));
$_;
} @{$change->{pages}}
];
diff --git a/debian/changelog b/debian/changelog
index 64614e727..3ba2d021a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,8 +16,9 @@ ikiwiki (1.39) UNRELEASED; urgency=low
a templatedir. Based on work by JeremyReed.
* In the aggregator, check for and deal with post filenames that are
longer than the maximum file length.
+ * Change the RecentChanges page to show the path of changed pages.
- -- Joey Hess <joeyh@debian.org> Sat, 13 Jan 2007 23:03:48 -0500
+ -- Joey Hess <joeyh@debian.org> Sat, 13 Jan 2007 23:30:20 -0500
ikiwiki (1.38) unstable; urgency=low
diff --git a/doc/index/discussion.mdwn b/doc/index/discussion.mdwn
index 0336e8342..4374130fa 100644
--- a/doc/index/discussion.mdwn
+++ b/doc/index/discussion.mdwn
@@ -197,21 +197,7 @@ The RecentChanges only shows the final file name for the recently changes file,
for example "discussion". It would be more useful to see "index/discussion"
or the path to the sub-page. I think this is handled by the htmllink() routine.
->> IMHO it's a good idea and I like it. Often I can see changes in
->> any discussion page, but I don't know without clicking the link
->> what discussion was changed.
-
->> However, I can see one problem here. You can commit via command line
->> changes in many pages. It will be displayed ugly then, because probably
->> a width of the RecentChanges page will be greater then a width of
->> user's browser. I hate these pages. So I propose to display a list of
->> changed pages in a column, not in a row. --Pawel
-
->>> Well, it's a simple [[patch|patchqueue/full_paths_in_recentchanges]].
->>> For a limited time I have that patch running on this wiki. Undecided if
->>> I like it or not; the width is not really a problem due to the design
->>> of the recentchanges page, but all those paths do clutter up the page
->>> somewhat. Comments? --[[Joey]]
+> Went ahead and did this, IMHO the display is ok as-is. --[[Joey]]
----
diff --git a/doc/patchqueue/full_paths_in_recentchanges.mdwn b/doc/patchqueue/full_paths_in_recentchanges.mdwn
deleted file mode 100644
index a42a2726b..000000000
--- a/doc/patchqueue/full_paths_in_recentchanges.mdwn
+++ /dev/null
@@ -1,15 +0,0 @@
-For my own refrence --[[Joey]]
-
- Index: CGI.pm
- ===================================================================
- --- CGI.pm (revision 2225)
- +++ CGI.pm (working copy)
- @@ -92,7 +92,7 @@
- delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
- $change->{pages} = [
- map {
- - $_->{link} = htmllink("", "", $_->{page}, 1);
- + $_->{link} = htmllink("", "", $_->{page}, 1, 0, pagetitle($_->{page}));
- $_;
- } @{$change->{pages}}
- ];