diff options
author | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-12 09:38:49 +0000 |
---|---|---|
committer | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-12 09:38:49 +0000 |
commit | 3276d28aa2188d936f90acff8a86f2f1b271a3eb (patch) | |
tree | 6b6e0ab2dd7ef3007d2c5bd4c9fc98ec6bf5df6f | |
parent | b1938a40e49c5dd19d28784650814ee8e6f158f2 (diff) | |
download | ikiwiki-3276d28aa2188d936f90acff8a86f2f1b271a3eb.tar ikiwiki-3276d28aa2188d936f90acff8a86f2f1b271a3eb.tar.gz |
remove patch graph for now, it's too early to graph bugs fixed thanks to
patches since I only recently started retaining used patches.
-rw-r--r-- | doc/todo.mdwn | 5 | ||||
-rw-r--r-- | doc/todo/correct_published_and_updated_time_information_for_the_feeds.mdwn | 113 |
2 files changed, 114 insertions, 4 deletions
diff --git a/doc/todo.mdwn b/doc/todo.mdwn index 81aca1989..eedfad4e1 100644 --- a/doc/todo.mdwn +++ b/doc/todo.mdwn @@ -10,10 +10,7 @@ max=12 ymin=10 formula=permonth style=bar barwidth=2 barspacing=1 height=13]] this many are being added per month [[postsparkline pages="todo/* and !todo and link(todo/done)" max=12 ymin=10 formula=permonth time=mtime style=bar barwidth=2 barspacing=1 height=13]] -while this many are being fixed (these -[[postsparkline pages="todo/* and !todo and (link(todo/done) or link(patch))" -max=12 ymin=10 formula=permonth time=mtime style=bar barwidth=2 barspacing=1 height=13]] -thanks to users' patches). +while this many are being fixed. """]] [[inline pages="todo/* and !todo/done and !link(todo/done) and diff --git a/doc/todo/correct_published_and_updated_time_information_for_the_feeds.mdwn b/doc/todo/correct_published_and_updated_time_information_for_the_feeds.mdwn new file mode 100644 index 000000000..082f0800c --- /dev/null +++ b/doc/todo/correct_published_and_updated_time_information_for_the_feeds.mdwn @@ -0,0 +1,113 @@ +In [Atom](http://www.ietf.org/rfc/rfc4287.txt), we can provide `published` and `updated` information. +In [RSS](http://cyber.law.harvard.edu/rss/rss.html), there is only `pubDate`, for the +publication date, but an update can be mentioned with the [`dc:modified`](http://www.ietf.org/rfc/rfc2413.txt) +element (whose datetime format is [iso 8601](http://www.w3.org/TR/NOTE-datetime)). +This patch updates :) `inline.pm` and the two relevant templates. + +> I tested a slightly modified patch, which I've put below for now. +> feedvalidator.org complains that dc:modified is not a known element. I'll +> bet some header needs to be added to make the dublin core stuff available. +> The atom feeds seem ok. --[[Joey]] + +<pre> +Index: debian/changelog +=================================================================== +--- debian/changelog (revision 4066) ++++ debian/changelog (working copy) +@@ -15,8 +15,11 @@ + * Updated French translation from Cyril Brulebois. Closes: #437181 + * The toc directive doesn't work well or make sense inside an inlined page. + Disable it when the page with the toc is nested inside another page. ++ * Apply a patch from NicolasLimare adding modification date tags to rss and ++ atom feeds, and also changing the publication time for a feed to the ++ newest modiciation time (was newest creation time). + +- -- Joey Hess <joeyh@debian.org> Sat, 11 Aug 2007 17:40:45 -0400 ++ -- Joey Hess <joeyh@debian.org> Sat, 11 Aug 2007 18:25:28 -0400 + + ikiwiki (2.5) unstable; urgency=low + +Index: templates/atomitem.tmpl +=================================================================== +--- templates/atomitem.tmpl (revision 4066) ++++ templates/atomitem.tmpl (working copy) +@@ -11,7 +11,8 @@ + <category term="<TMPL_VAR CATEGORY>" /> + </TMPL_LOOP> + </TMPL_IF> +- <updated><TMPL_VAR DATE_3339></updated> ++ <updated><TMPL_VAR MDATE_3339></updated> ++ <published><TMPL_VAR CDATE_3339></published> + <TMPL_IF NAME="ENCLOSURE"> + <link rel="enclosure" type="<TMPL_VAR TYPE>" href="<TMPL_VAR ENCLOSURE>" length="<TMPL_VAR LENGTH>" /> + <TMPL_ELSE> +Index: templates/rssitem.tmpl +=================================================================== +--- templates/rssitem.tmpl (revision 4066) ++++ templates/rssitem.tmpl (working copy) +@@ -12,7 +12,8 @@ + <category><TMPL_VAR CATEGORY></category> + </TMPL_LOOP> + </TMPL_IF> +- <pubDate><TMPL_VAR DATE_822></pubDate> ++ <pubDate><TMPL_VAR CDATE_822></pubDate> ++ <dc:modified><TMPL_VAR MDATE_3339></dc:modified> + <TMPL_IF NAME="ENCLOSURE"> + <enclosure url="<TMPL_VAR ENCLOSURE>" type="<TMPL_VAR TYPE>" length="<TMPL_VAR LENGTH>" /> + <TMPL_ELSE> +Index: IkiWiki/Plugin/inline.pm +=================================================================== +--- IkiWiki/Plugin/inline.pm (revision 4066) ++++ IkiWiki/Plugin/inline.pm (working copy) +@@ -361,8 +361,10 @@ + title => pagetitle(basename($p)), + url => $u, + permalink => $u, +- date_822 => date_822($pagectime{$p}), +- date_3339 => date_3339($pagectime{$p}), ++ cdate_822 => date_822($pagectime{$p}), ++ mdate_822 => date_822($pagemtime{$p}), ++ cdate_3339 => date_3339($pagectime{$p}), ++ mdate_3339 => date_3339($pagemtime{$p}), + ); + + if ($itemtemplate->query(name => "enclosure")) { +@@ -397,7 +399,7 @@ + $content.=$itemtemplate->output; + $itemtemplate->clear_params; + +- $lasttime = $pagectime{$p} if $pagectime{$p} > $lasttime; ++ $lasttime = $pagemtime{$p} if $pagemtime{$p} > $lasttime; + } + + my $template=template($feedtype."page.tmpl", blind_cache => 1); +</pre> + + + +>> Yes I noticedthe bug today; the correct (tested on feedvalidator) rssitem.tmpl template must start with the following content: + + <item> + <TMPL_IF NAME="AUTHOR"> + <title><TMPL_VAR AUTHOR ESCAPE=HTML>: <TMPL_VAR TITLE></title> + <dcterms:creator><TMPL_VAR AUTHOR ESCAPE=HTML></dcterms:creator> + <TMPL_ELSE> + <title><TMPL_VAR TITLE></title> + </TMPL_IF> + <dcterms:modified><TMPL_VAR MDATE_3339></dcterms:modified> + <dcterms:created><TMPL_VAR DATE_3339></dcterms:created> + .... + +>> and rsspage.tmpl must start with: + + <?xml version="1.0"?> + <rss version="2.0" + xmlns:dc="http://purl.org/dc/elements/1.1/" + xmlns:dcterms="http://purl.org/dc/terms/" > + .... + +>> — [[NicolasLimare]] + +[[done]] --[[Joey]] + +[[tag patch]] |