diff options
Diffstat (limited to 'guix-qa-frontpage/view/issue.scm')
-rw-r--r-- | guix-qa-frontpage/view/issue.scm | 47 |
1 files changed, 33 insertions, 14 deletions
diff --git a/guix-qa-frontpage/view/issue.scm b/guix-qa-frontpage/view/issue.scm index fc5915d..0edb034 100644 --- a/guix-qa-frontpage/view/issue.scm +++ b/guix-qa-frontpage/view/issue.scm @@ -12,6 +12,8 @@ issue-package-changes-view)) (define (issue-view issue-number series mumi-tags + base-and-target-refs + create-branch-for-issue-log comparison-link derivation-changes builds-missing? @@ -33,18 +35,20 @@ (a (@ (href ,(simple-format #f "https://issues.guix.gnu.org/~A" issue-number))) "View issue on issues.guix.gnu.org")) - (li - (a (@ (href - ,(let ((branch-name - (simple-format #f "issue-~A" issue-number)) - (base-tag - (simple-format #f "base-for-issue-~A" issue-number))) - (simple-format - #f - "~A/log/?h=~A&qt=range&q=~A..~A" - "https://git.guix-patches.cbaines.net/guix-patches" - branch-name base-tag branch-name)))) - "View Git branch")) + ,@(if base-and-target-refs + `((li + (a (@ (href + ,(let ((branch-name + (simple-format #f "issue-~A" issue-number)) + (base-tag + (simple-format #f "base-for-issue-~A" issue-number))) + (simple-format + #f + "~A/log/?h=~A&qt=range&q=~A..~A" + "https://git.guix-patches.cbaines.net/guix-patches" + branch-name base-tag branch-name)))) + "View Git branch"))) + '()) (li (a (@ (href ,(assoc-ref series "web_url"))) "View series on Patchwork")) @@ -236,6 +240,11 @@ td.bad { border: 0.3rem dashed red; } +div.bad { + padding: 0.05rem 0.65rem; + border: 0.3rem dashed red; +} + .tag { display: inline-block; padding: 0.25em 0.4em; @@ -267,8 +276,18 @@ td.bad { `(li ,(assoc-ref patch "name"))) (assoc-ref series "patches"))) - ,lint-warnings-div - ,package-changes-div + ,@(if base-and-target-refs + `(,lint-warnings-div + ,package-changes-div) + `((div + (@ (class "bad") + (style "width: fit-content;")) + (h3 "Unable to apply " + ,(if (= 0 (length (assoc-ref series "patches"))) + "patch" + "patches")) + (pre ,create-branch-for-issue-log)))) + ,review-checklist-div (div |