aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHakim El Hattab <hakim.elhattab@gmail.com>2014-05-14 08:50:28 +0200
committerHakim El Hattab <hakim.elhattab@gmail.com>2014-05-14 08:50:28 +0200
commitb9d25057d688dbe8aef4df7a8baa0dcb33137370 (patch)
tree39b2b676fd7b11387e24800bc1bd1ad9b9476fa7
parent54c3c23e363e99772be4f0db30b177c2bffc1b39 (diff)
parentffecac6df30b00cf35588a00299b610b76a953f2 (diff)
downloadfreenode-live-2017-presentation-b9d25057d688dbe8aef4df7a8baa0dcb33137370.tar
freenode-live-2017-presentation-b9d25057d688dbe8aef4df7a8baa0dcb33137370.tar.gz
Merge branch 'fix-isFirstSlide' of https://github.com/fabianorosas/reveal.js into dev
-rw-r--r--js/reveal.js2
-rw-r--r--test/test.js16
2 files changed, 16 insertions, 2 deletions
diff --git a/js/reveal.js b/js/reveal.js
index 8c0889b..1ff0dcb 100644
--- a/js/reveal.js
+++ b/js/reveal.js
@@ -3909,7 +3909,7 @@
// Returns true if we're currently on the first slide
isFirstSlide: function() {
- return document.querySelector( SLIDES_SELECTOR + '.past' ) == null ? true : false;
+ return ( indexh === 0 && indexv === 0 );
},
// Returns true if we're currently on the last slide
diff --git a/test/test.js b/test/test.js
index 00f9080..6c7270f 100644
--- a/test/test.js
+++ b/test/test.js
@@ -68,6 +68,12 @@ Reveal.addEventListener( 'ready', function() {
strictEqual( Reveal.isFirstSlide(), true, 'true after Reveal.slide( 0, 0 )' );
});
+ test( 'Reveal.isFirstSlide after vertical slide', function() {
+ Reveal.slide( 1, 1 );
+ Reveal.slide( 0, 0 );
+ strictEqual( Reveal.isFirstSlide(), true, 'true after Reveal.slide( 1, 1 ) and then Reveal.slide( 0, 0 )' );
+ });
+
test( 'Reveal.isLastSlide', function() {
Reveal.slide( 0, 0 );
strictEqual( Reveal.isLastSlide(), false, 'false after Reveal.slide( 0, 0 )' );
@@ -75,12 +81,20 @@ Reveal.addEventListener( 'ready', function() {
var lastSlideIndex = document.querySelectorAll( '.reveal .slides>section' ).length - 1;
Reveal.slide( lastSlideIndex, 0 );
- strictEqual( Reveal.isLastSlide(), true, 'true after Reveal.slide( ', 0+ lastSlideIndex +' )' );
+ strictEqual( Reveal.isLastSlide(), true, 'true after Reveal.slide( '+ lastSlideIndex +', 0 )' );
Reveal.slide( 0, 0 );
strictEqual( Reveal.isLastSlide(), false, 'false after Reveal.slide( 0, 0 )' );
});
+ test( 'Reveal.isLastSlide after vertical slide', function() {
+ var lastSlideIndex = document.querySelectorAll( '.reveal .slides>section' ).length - 1;
+
+ Reveal.slide( 1, 1 );
+ Reveal.slide( lastSlideIndex );
+ strictEqual( Reveal.isLastSlide(), true, 'true after Reveal.slide( 1, 1 ) and then Reveal.slide( '+ lastSlideIndex +', 0 )' );
+ });
+
test( 'Reveal.getTotalSlides', function() {
strictEqual( Reveal.getTotalSlides(), 8, 'eight slides in total' );
});