diff options
author | Christopher Baines <mail@cbaines.net> | 2020-01-18 10:18:17 +0000 |
---|---|---|
committer | Christopher Baines <mail@cbaines.net> | 2020-01-18 10:18:17 +0000 |
commit | 704f1496451e380c356a90d85e614277025c1ef4 (patch) | |
tree | d0f033850b8cc5b43aa1d6ddb7356e1d97f45d20 | |
parent | cf407fe83035cda4881314c2dcd3d6a2367609c7 (diff) | |
download | data-service-704f1496451e380c356a90d85e614277025c1ef4.tar data-service-704f1496451e380c356a90d85e614277025c1ef4.tar.gz |
Improve the compare-invalid-parameters messages
-rw-r--r-- | guix-data-service/web/compare/html.scm | 30 |
1 files changed, 20 insertions, 10 deletions
diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm index f493714..c96967a 100644 --- a/guix-data-service/web/compare/html.scm +++ b/guix-data-service/web/compare/html.scm @@ -970,16 +970,26 @@ (div (@ (class "container")) (h1 "Unknown commit") ,(if (invalid-query-parameter? base-commit) - `(p "No known revision with commit " - (strong (samp ,(invalid-query-parameter-value base-commit))) - ,(if (null? base-job) - " and it is not currently queued for processing" - " but it is queued for processing")) + (if (null? base-job) + `(p "No known revision with commit " + (strong (samp ,(invalid-query-parameter-value base-commit))) + ".") + `(p "Revision " + (a (@ (href + ,(string-append "/revision/" + (invalid-query-parameter-value base-commit)))) + (strong (samp ,(invalid-query-parameter-value base-commit)))) + " is queued for processing.")) '()) ,(if (invalid-query-parameter? target-commit) - `(p "No known revision with commit " - (strong (samp ,(invalid-query-parameter-value target-commit))) - ,(if (null? target-job) - " and it is not currently queued for processing" - " but it is queued for processing")) + (if (null? target-job) + `(p "No known revision with commit " + (strong (samp ,(invalid-query-parameter-value target-commit))) + ".") + `(p "Revision " + (a (@ (href + ,(string-append "/revision/" + (invalid-query-parameter-value target-commit)))) + (strong (samp ,(invalid-query-parameter-value target-commit)))) + " is queued for processing.")) '()))))) |