diff options
author | Ludovic Courtès <ludo@gnu.org> | 2022-05-31 17:17:10 +0200 |
---|---|---|
committer | Ludovic Courtès <ludo@gnu.org> | 2022-07-01 23:29:16 +0200 |
commit | 4ff12d1de7cd617b791996ee7ca1240660b4c20e (patch) | |
tree | 27bf6c0c43864848dd7db1ef08fc4d38d7a27ff3 /tests/system.scm | |
parent | 9b8c442b254b82196fe2492142b3c3bbbd891a1b (diff) | |
download | guix-4ff12d1de7cd617b791996ee7ca1240660b4c20e.tar guix-4ff12d1de7cd617b791996ee7ca1240660b4c20e.tar.gz |
profiles: Do not repeat entries in 'manifest' file.
Fixes <https://issues.guix.gnu.org/55499>.
Reported by Ricardo Wurmus <rekado@elephly.net>.
With this change, the manifest file created for:
guix install r r-seurat r-cistopic r-monocle3 r-cicero-monocle3 r-assertthat
goes from 5.7M to 176K. Likewise, on this profile, wall-clock time of:
GUIX_PROFILING=gc guix package -I
goes from 0.7s to 0.1s, with heap usage going from 55M to 9M.
* guix/profiles.scm (manifest->gexp)[optional]: New procedure.
[entry->gexp]: Turn into a monadic procedure. Return a 'repeated' sexp
if ENTRY was already visited before.
Adjust caller accordingly. Bump manifest version.
(sexp->manifest)[sexp->manifest-entry]: Turn into a monadic procedure.
Add case for 'repeated' nodes. Add each entry to the current state
vhash.
Add clause for version 4 manifests.
[sexp->manifest-entry/v3]: New procedure, with former
'sexp->manifest-entry' code.
* tests/profiles.scm ("deduplication of repeated entries"): New test.
* guix/build/profiles.scm (manifest-sexp->inputs+search-paths)[let-fields]:
New macro.
Use it. Expect version 4. Add clause for 'repeated' nodes.
Diffstat (limited to 'tests/system.scm')
0 files changed, 0 insertions, 0 deletions