diff options
author | Eric Bavier <bavier@posteo.net> | 2023-04-20 00:11:27 -0500 |
---|---|---|
committer | Ludovic Courtès <ludo@gnu.org> | 2023-04-21 16:16:38 +0200 |
commit | 37dd69b44511dc73eb04bdebe8d82c9a0386338e (patch) | |
tree | d20ecc2b15659ed2345f00beb39170a5365a7051 /tests/guix-git-authenticate.sh | |
parent | a09c7da8f8d8e732f969cf0a09aaa78f87032ab1 (diff) | |
download | guix-37dd69b44511dc73eb04bdebe8d82c9a0386338e.tar guix-37dd69b44511dc73eb04bdebe8d82c9a0386338e.tar.gz |
tests: Fix checks for expected failures.
Addresses <https://issues.guix.gnu.org/62406>.
With 'set -e', a return status inverted with '!' does not cause the shell to
exit immediately. Instead use '&& false' to indicate an expected failure.
* tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh,
tests/guix-daemon.sh, tests/guix-download.sh,
tests/guix-environment-container.sh, tests/guix-environment.sh,
tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh,
tests/guix-hash.sh, tests/guix-home.sh, tests/guix-pack-relocatable.sh,
tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh,
tests/guix-package.sh, tests/guix-refresh.sh, tests/guix-shell.sh,
tests/guix-style.sh, tests/guix-system.sh: Replace uses of '! ...' with
'... && false' or `test ! ...` as appropriate.
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Diffstat (limited to 'tests/guix-git-authenticate.sh')
-rw-r--r-- | tests/guix-git-authenticate.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/guix-git-authenticate.sh b/tests/guix-git-authenticate.sh index 2b90d8a4af..ec89f941e6 100644 --- a/tests/guix-git-authenticate.sh +++ b/tests/guix-git-authenticate.sh @@ -35,9 +35,9 @@ intro_signer="BBB0 2DDF 2CEA F6A8 0D1D E643 A2A0 6DF2 A33A 54FA" cache_key="test-$$" # This must fail because the end commit is not a descendant of $intro_commit. -! guix git authenticate "$intro_commit" "$intro_signer" \ +guix git authenticate "$intro_commit" "$intro_signer" \ --cache-key="$cache_key" --stats \ - --end=9549f0283a78fe36f2d4ff2a04ef8ad6b0c02604 + --end=9549f0283a78fe36f2d4ff2a04ef8ad6b0c02604 && false # The v1.2.0 commit is a descendant of $intro_commit and it satisfies the # authorization invariant. @@ -59,8 +59,8 @@ guix git authenticate "$intro_commit" "$intro_signer" \ --end="$v1_0_0_commit" # This should fail because these commits lack '.guix-authorizations'. -! guix git authenticate "$v1_0_0_commit" "$v1_0_0_signer" \ - --cache-key="$cache_key" --end="$v1_0_1_commit" +guix git authenticate "$v1_0_0_commit" "$v1_0_0_signer" \ + --cache-key="$cache_key" --end="$v1_0_1_commit" && false # This should work thanks to '--historical-authorizations'. guix git authenticate "$v1_0_0_commit" "$v1_0_0_signer" \ |