diff options
author | Ludovic Courtès <ludo@gnu.org> | 2018-03-07 10:00:07 +0100 |
---|---|---|
committer | Ludovic Courtès <ludo@gnu.org> | 2018-03-07 11:22:42 +0100 |
commit | 6c4458172d12dbda969c2eae5b3b6be19a068780 (patch) | |
tree | 6f1421d919d64a8aaa0eb9c816a9c8463748f4c9 /gnu/system/install.scm | |
parent | 366ddc1ac549efee9acd1fddd30c9baee89ec18a (diff) | |
download | guix-6c4458172d12dbda969c2eae5b3b6be19a068780.tar guix-6c4458172d12dbda969c2eae5b3b6be19a068780.tar.gz |
services: file-systems: Include 'user-file-systems' service.
Previously the KNOWN-FS value used in 'essential-services' would be
incomplete: it would lack all the file systems provided by services that
extend 'file-system-service-type' (/sys/fs/cgroup,
/proc/sys/fs/binfmt_misc, etc.) Consequently, upon shutdown,
'user-processes' would unmount these file systems before their
corresponding service had been stopped; when their corresponding (e.g.,
'file-system-/proc/sys/fs/binfmt_misc') was stopped, its 'umount' call
would fail.
This was harmless in practice, but this patch makes sure things work as
intended and file systems are unmounted in the right order.
* gnu/services/base.scm (file-system-shepherd-services): Instantiate
'user-file-systems' Shepherd service from here.
(user-unmount-service-type, user-unmount-service): Remove.
* gnu/system.scm (essential-services): Remove call to 'user-unmount-service'.
* gnu/system/install.scm (cow-store-service-type): Adjust comment.
Diffstat (limited to 'gnu/system/install.scm')
-rw-r--r-- | gnu/system/install.scm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gnu/system/install.scm b/gnu/system/install.scm index 37c591ec3a..97f5abe0b6 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -133,7 +133,7 @@ the given target.") (stop #~(lambda (target) ;; Delete the temporary directory, but leave everything ;; mounted as there may still be processes using it since - ;; 'user-processes' doesn't depend on us. The 'user-unmount' + ;; 'user-processes' doesn't depend on us. The 'user-file-systems' ;; service will unmount TARGET eventually. (delete-file-recursively (string-append target #$%backing-directory)))))))) |