aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2012-10-22 23:30:35 +0200
committerLudovic Courtès <ludo@gnu.org>2012-10-24 00:09:25 +0200
commitd90248844bc6e4400c999047a292c318a1cf1103 (patch)
tree8234213e55d14acd327fa5f62440c4be0028e2ef
parentd398e2c2426cd50a97603b0be6da999e67947def (diff)
downloadguix-d90248844bc6e4400c999047a292c318a1cf1103.tar
guix-d90248844bc6e4400c999047a292c318a1cf1103.tar.gz
derivations: Compile the #:modules passed to `build-expression->derivation'.
* guix/derivations.scm (imported-files)[parent-dirs]: Move to... (parent-directories): ... here. New procedure. (compiled-modules): New procedure. (build-expression->derivation): Use it. * tests/derivations.scm ("build-expression->derivation with modules"): New test.
-rw-r--r--guix/derivations.scm102
-rw-r--r--tests/derivations.scm17
2 files changed, 96 insertions, 23 deletions
diff --git a/guix/derivations.scm b/guix/derivations.scm
index 4ecf85aca2..ebb1ab5fa7 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -453,27 +453,27 @@ known in advance, such as a file download."
;; when using `build-expression->derivation'.
(make-parameter (false-if-exception (nixpkgs-derivation* "guile"))))
+(define (parent-directories file-name)
+ "Return the list of parent dirs of FILE-NAME, in the order in which an
+`mkdir -p' implementation would make them."
+ (let ((not-slash (char-set-complement (char-set #\/))))
+ (reverse
+ (fold (lambda (dir result)
+ (match result
+ (()
+ (list dir))
+ ((prev _ ...)
+ (cons (string-append prev "/" dir)
+ result))))
+ '()
+ (remove (cut string=? <> ".")
+ (string-tokenize (dirname file-name) not-slash))))))
+
(define* (imported-files store files
#:key (name "file-import") (system (%current-system)))
"Return a derivation that imports FILES into STORE. FILES must be a list
of (FINAL-PATH . FILE-NAME) pairs; each FILE-NAME is read from the file
system, imported, and appears under FINAL-PATH in the resulting store path."
- (define (parent-dirs file-name)
- ;; Return the list of parent dirs of FILE-NAME, in the order in which an
- ;; `mkdir -p' implementation would make them.
- (let ((not-slash (char-set-complement (char-set #\/))))
- (reverse
- (fold (lambda (dir result)
- (match result
- (()
- (list dir))
- ((prev _ ...)
- (cons (string-append prev "/" dir)
- result))))
- '()
- (remove (cut string=? <> ".")
- (string-tokenize (dirname file-name) not-slash))))))
-
(let* ((files (map (match-lambda
((final-path . file-name)
(list final-path
@@ -485,7 +485,7 @@ system, imported, and appears under FINAL-PATH in the resulting store path."
(mkdir %output) (chdir %output)
,@(append-map (match-lambda
((final-path store-path)
- (append (match (parent-dirs final-path)
+ (append (match (parent-directories final-path)
(() '())
((head ... tail)
(append (map (lambda (d)
@@ -515,6 +515,46 @@ search path."
modules)))
(imported-files store files #:name name #:system system)))
+(define* (compiled-modules store modules
+ #:key (name "module-import-compiled")
+ (system (%current-system)))
+ "Return a derivation that builds a tree containing the `.go' files
+corresponding to MODULES. All the MODULES are built in a context where
+they can refer to each other."
+ (let* ((module-drv (imported-modules store modules
+ #:system system))
+ (module-dir (derivation-path->output-path module-drv))
+ (files (map (lambda (m)
+ (let ((f (string-join (map symbol->string m)
+ "/")))
+ (cons (string-append f ".go")
+ (string-append module-dir "/" f ".scm"))))
+ modules)))
+ (define builder
+ `(begin
+ (use-modules (system base compile))
+ (let ((out (assoc-ref %outputs "out")))
+ (mkdir out)
+ (chdir out))
+
+ (set! %load-path
+ (cons ,module-dir %load-path))
+
+ ,@(map (match-lambda
+ ((output . input)
+ (let ((make-parent-dirs (map (lambda (dir)
+ `(unless (file-exists? ,dir)
+ (mkdir ,dir)))
+ (parent-directories output))))
+ `(begin
+ ,@make-parent-dirs
+ (compile-file ,input
+ #:output-file ,output
+ #:opts %auto-compilation-options)))))
+ files)))
+
+ (build-expression->derivation store name system builder
+ `(("modules" ,module-drv)))))
(define* (build-expression->derivation store name system exp inputs
#:key (outputs '("out"))
@@ -571,6 +611,11 @@ omitted or is #f, the value of the `%guile-for-build' fluid is used instead."
drv)))))
inputs))
+ ,@(if (null? modules)
+ '()
+ ;; Remove our own settings.
+ '((unsetenv "GUILE_LOAD_COMPILED_PATH")))
+
;; Guile sets it, but remove it to avoid conflicts when
;; building Guile-using packages.
(unsetenv "LD_LIBRARY_PATH")))
@@ -585,19 +630,30 @@ omitted or is #f, the value of the `%guile-for-build' fluid is used instead."
(remove module-form? exp))
(_ `(,exp))))))
(map second inputs)))
- (mod-drv (if (null? modules)
- #f
- (imported-modules store modules)))
+ (mod-drv (and (pair? modules)
+ (imported-modules store modules)))
(mod-dir (and mod-drv
- (derivation-path->output-path mod-drv))))
+ (derivation-path->output-path mod-drv)))
+ (go-drv (and (pair? modules)
+ (compiled-modules store modules)))
+ (go-dir (and go-drv
+ (derivation-path->output-path go-drv))))
(derivation store name system guile
`("--no-auto-compile"
,@(if mod-dir `("-L" ,mod-dir) '())
,builder)
- env-vars
+
+ ;; When MODULES is non-empty, shamelessly clobber
+ ;; $GUILE_LOAD_COMPILED_PATH.
+ (if go-dir
+ `(("GUILE_LOAD_COMPILED_PATH" . ,go-dir)
+ ,@(alist-delete "GUILE_LOAD_COMPILED_PATH"
+ env-vars))
+ env-vars)
+
`((,(or guile-for-build (%guile-for-build)))
(,builder)
,@(map cdr inputs)
- ,@(if mod-drv `((,mod-drv)) '()))
+ ,@(if mod-drv `((,mod-drv) (,go-drv)) '()))
#:hash hash #:hash-algo hash-algo
#:outputs outputs)))
diff --git a/tests/derivations.scm b/tests/derivations.scm
index 097b9d7d28..95507aa780 100644
--- a/tests/derivations.scm
+++ b/tests/derivations.scm
@@ -324,6 +324,23 @@
get-bytevector-all))))
files)))))
+(test-assert "build-expression->derivation with modules"
+ (let* ((builder `(begin
+ (use-modules (guix build utils))
+ (let ((out (assoc-ref %outputs "out")))
+ (mkdir-p (string-append out "/guile/guix/nix"))
+ #t)))
+ (drv-path (build-expression->derivation %store
+ "test-with-modules"
+ (%current-system)
+ builder '()
+ #:modules
+ '((guix build utils)))))
+ (and (build-derivations %store (list drv-path))
+ (let* ((p (derivation-path->output-path drv-path))
+ (s (stat (string-append p "/guile/guix/nix"))))
+ (eq? (stat:type s) 'directory)))))
+
(test-skip (if (false-if-exception (getaddrinfo "ftp.gnu.org" "http"))
0
1))