Fix and improve the fetch revision job

1 files changed, 15 insertions, 15 deletions

diff --git a/app/jobs/govuk_guix/fetch_revision_job.rb b/app/jobs/govuk_guix/fetch_revision_job.rb
index 8f9ebdf..19ae78c 100644
--- a/app/jobs/govuk_guix/fetch_revision_job.rb
+++ b/app/jobs/govuk_guix/fetch_revision_job.rb
@@ -14,27 +14,27 @@ class GovukGuix::FetchRevisionJob < GovukGuix::Job
 
     command = [
       "#{repository_directory}/guix-pre-inst-env",
-      "guix",
-      "build",
-      "-e",
-      "(begin (use-modules (gds packages govuk)) (current-govuk-guix))"
+      'guix',
+      'build',
+      '-e',
+      '(begin (use-modules (gds packages govuk)) (current-govuk-guix))'
     ]
 
-    run_command(command) do |output|
-      store_path = output.last.strip
-      logger.debug("FetchRevisionJob: store_path: #{store_path}")
-      
-      GovukGuix::Revision.create(
-        commit_hash: sha,
-        store_path: store_path
-      )
-    end
+    output = run_command(*command)
+
+    store_path = output.last.strip
+    logger.debug(self.class) { "store_path: #{store_path}" }
+
+    GovukGuix::Revision.create(
+      commit_hash: sha,
+      store_path: store_path
+    )
   end
 
   def repository
     @_repository ||= begin
-      if File.exists? repository_directory
-        Git.open(repository_directory, :log => Rails.logger)
+      if File.exist? repository_directory
+        Git.open(repository_directory, log: Rails.logger)
       else
         Git.clone(repository_remote_location, repository_directory)
       end