aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2013-02-11 14:42:33 -0500
committerNick Mathewson <nickm@torproject.org>2013-02-11 14:42:33 -0500
commitb9432becbe0ff10788e8f289b6562720822b7ece (patch)
tree66482c1e7abf40cf685b268308e0ee446f3573a7
parentffd6e557cbd0754dc26808dadf721227c8047788 (diff)
downloadtor-b9432becbe0ff10788e8f289b6562720822b7ece.tar
tor-b9432becbe0ff10788e8f289b6562720822b7ece.tar.gz
Fix a copy-and-paste issue found by coverity
Fixes CID 980650; bugfix on 0.2.4.10-alpha.
-rw-r--r--changes/cov9806504
-rw-r--r--src/or/routerset.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/changes/cov980650 b/changes/cov980650
new file mode 100644
index 000000000..cbbada2e6
--- /dev/null
+++ b/changes/cov980650
@@ -0,0 +1,4 @@
+ o Minor bugfixes:
+ - Fix a copy-and-paste error when adding a missing A1 to a routerset
+ because of GeoIPExcludeUnknown. Fix for coverity CID 980650.
+ Bugfix on 0.2.4.10-alpha.
diff --git a/src/or/routerset.c b/src/or/routerset.c
index e45516bb6..1eca5b6f6 100644
--- a/src/or/routerset.c
+++ b/src/or/routerset.c
@@ -255,7 +255,7 @@ routerset_add_unknown_ccs(routerset_t **setp, int only_if_some_cc_set)
}
if (add_a1) {
smartlist_add(set->country_names, tor_strdup("a1"));
- smartlist_add(set->country_names, tor_strdup("{a1}"));
+ smartlist_add(set->list, tor_strdup("{a1}"));
}
if (add_unknown || add_a1) {