aboutsummaryrefslogtreecommitdiff
path: root/doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-08-30 15:08:07 -0400
committerJoey Hess <joey@kitenet.net>2010-08-30 15:08:07 -0400
commitbdafa441babb9bf73b8c25852eed1a115ca5b8e7 (patch)
tree8111f58b81f2d67f6d6d5d09c093abc24f6a68fe /doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn
parent4e14c5e793178eda34042e027bb01e963f1dae7b (diff)
downloadikiwiki-bdafa441babb9bf73b8c25852eed1a115ca5b8e7.tar
ikiwiki-bdafa441babb9bf73b8c25852eed1a115ca5b8e7.tar.gz
close bug; more rationalle for reordering
Diffstat (limited to 'doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn')
-rw-r--r--doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn15
1 files changed, 15 insertions, 0 deletions
diff --git a/doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn b/doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn
index 402f70b79..9bb9c72c4 100644
--- a/doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn
+++ b/doc/todo/po:_avoid_rebuilding_to_fix_meta_titles.mdwn
@@ -43,3 +43,18 @@ Re the meta title escaping issue worked around by `change`.
>>>>>> did not dare to. I'll try this. --[[intrigeri]]
>>>>>>> Done in my po branch, please have a look. --[[intrigeri]]
+
+>>>>>>>> I've merged it. Didn't look at the po.pm changes closely;
+>>>>>>>> assume they're ok. [[done]] --[[Joey]]
+>>>>>>>>
+>>>>>>>> My thinking about the reordering being safe is that
+>>>>>>>> the relative ordering of scan and preprocess in scan mode hooks
+>>>>>>>> has not been defined before, so it should be ok to define it. :)
+>>>>>>>>
+>>>>>>>> And as to possible breakage from things that assumed the old
+>>>>>>>> ordering, such a thing would need to have a scan hook and a
+>>>>>>>> preprocess in scan mode hook, and the two hooks would need to
+>>>>>>>> populate the same data structure with conflicting information,
+>>>>>>>> in order for there to be a problem. That seems highly unlikely
+>>>>>>>> and would be pretty broken on its own. And no plugin in ikiwiki
+>>>>>>>> itself has both types of hooks. --[[Joey]]