aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2011-02-22 17:32:01 -0400
committerJoey Hess <joey@kitenet.net>2011-02-22 17:32:01 -0400
commitdb38cad40f9614ce1c37c818415d430db07813b8 (patch)
tree3209c2d92cbf91c41a31316c94da98e160086da1
parent9836bceaa520919530e4311582b4fee2fd5c4e36 (diff)
downloadikiwiki-db38cad40f9614ce1c37c818415d430db07813b8.tar
ikiwiki-db38cad40f9614ce1c37c818415d430db07813b8.tar.gz
reviewing next patch
-rw-r--r--doc/todo/feed_enhancements_for_inline_pages.mdwn7
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/todo/feed_enhancements_for_inline_pages.mdwn b/doc/todo/feed_enhancements_for_inline_pages.mdwn
index 02b4e9d36..4e80fdeb8 100644
--- a/doc/todo/feed_enhancements_for_inline_pages.mdwn
+++ b/doc/todo/feed_enhancements_for_inline_pages.mdwn
@@ -36,6 +36,13 @@ description is provided by either the directive parameter or the page
metadata, we use a user-configurable default based on both the page
title and wiki name rather than hard-coding the wiki name as description.
+> Reviewing, this seems ok, but I don't like that
+> `feed_desc_fmt` is "safe => 0". And I question if that needs
+> to be configurable at all. I say, drop that configurable, and
+> only use the page meta description (or wikiname for index).
+>
+> Oh, and could you indent your `elsif` the same as I? --[[Joey]]
+
The third patch, ‘inline: allow assigning an id to postform/feedlink’,
does just that. I don't currently use it, but it can be particularly
useful in the postform case for example for scriptable management of