aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhttps://id.koumbit.net/anarcat <https://id.koumbit.net/anarcat@web>2011-10-11 13:07:48 -0400
committeradmin <admin@branchable.com>2011-10-11 13:07:48 -0400
commit76f09c135367eff07d18e61741bca8e38cdb9f03 (patch)
tree5d6fd7dd66b1a632da13f7ecc394344c84461684
parent2c8ca894d6b773db2c7c278cfc4dd62ff54cdc43 (diff)
downloadikiwiki-76f09c135367eff07d18e61741bca8e38cdb9f03.tar
ikiwiki-76f09c135367eff07d18e61741bca8e38cdb9f03.tar.gz
-rw-r--r--doc/plugins/recentchangesdiff/Discussion.mdwn20
1 files changed, 20 insertions, 0 deletions
diff --git a/doc/plugins/recentchangesdiff/Discussion.mdwn b/doc/plugins/recentchangesdiff/Discussion.mdwn
new file mode 100644
index 000000000..55bb542f7
--- /dev/null
+++ b/doc/plugins/recentchangesdiff/Discussion.mdwn
@@ -0,0 +1,20 @@
+couldn't the diff be displayed as a popup? right now it's too bad because the diff is actually in the page, generated and downloaded, but the user can't see it. I have tried to address the issue by adding stuff to the change.tmpl template, but I may be missing something - and it doesn't quite look right:
+
+ --- /usr/share/ikiwiki/templates/change.tmpl 2011-09-05 15:14:19.000000000 -0400
+ +++ templates/change.tmpl 2011-10-11 13:04:37.704346964 -0400
+ @@ -39,6 +39,7 @@
+ </TMPL_LOOP>
+ </div>
+ <TMPL_IF DIFF>
+ +<a href="#" onClick="document.getElementByClass('diff').style = 'block'">[[show diff|wikiicons/diff.png]]</a>
+ <div class="diff">
+ <pre>
+ <TMPL_VAR DIFF>
+
+There are a few things wrong with this:
+
+ 1. I don't like the hardcoded javascript in there, we should use [[plugins/toggle]] or something, but i am not sure how to make the this plugin depend on toggle, or if it is desirable.
+ 2. it doesn't work at all: first it doesn't actually "toggle" and second the javascript somehow gets filtered out of the resulting HTML so we don't even see it
+ 3. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly. i tried moving the diff button upwards into the PAGES loop, but there the diffurls are file-specific, which also seem quite silly
+
+I am looking for guidance on how to improve and fix this now. --[[anarcat]] 2011-10-11