aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Hess <joey@kodama.kitenet.net>2008-10-01 17:23:46 -0400
committerJoey Hess <joey@kodama.kitenet.net>2008-10-01 17:23:46 -0400
commit06de9da609bb79438729c686ca5721d0415b4894 (patch)
treeb33cb6e05f47b364ecaa9f07778040a256522781
parentf7431af308a9b36d1323ff380344cb3092786e19 (diff)
downloadikiwiki-06de9da609bb79438729c686ca5721d0415b4894.tar
ikiwiki-06de9da609bb79438729c686ca5721d0415b4894.tar.gz
first review
-rw-r--r--doc/todo/darcs.mdwn17
1 files changed, 17 insertions, 0 deletions
diff --git a/doc/todo/darcs.mdwn b/doc/todo/darcs.mdwn
index 512a7ba0a..a410f5ecf 100644
--- a/doc/todo/darcs.mdwn
+++ b/doc/todo/darcs.mdwn
@@ -506,4 +506,21 @@ Regarding the repository layout: There are two darcs repositories. One is the `s
* The backend pushes CGI edits from `srcdir` back into `master` (triggering the apply hook).
* The working copies in `srcdir` and `master` should *not* be touched by the user, only by the CGI or darcs, respectively.
+> Review of this one:
+>
+> * Should use tab indentation.
+> * `rcs_getctime` should not need to use a ctime cache (such a cache should
+> also not be named `.ikiwiki.ctimes`). `rcs_getctime` is run exactly
+> once per page, ever, and the data is cached in ikiwiki's index.
+> * I doubt that ENV{DARCS} will be available, since the wrapper clobbers> the entire
+> environment. I'd say remove that.
+> * I don't understand what `darcs_info` is doing, but it seems to be
+> parsing xml with a regexp?
+> * Looks like `rcs_commit` needs a few improvements, as marked TODO
+> * `rcs_remove` just calls "rm"? Does darcs record notice the file was removed
+> and automatically commit the removal? (And why `system("rm")` and not
+> `unlink`?)
+> * Is the the darcs info in [[details]] still up-to-date re this version?
+> --[[Joey]]
+
[[!tag patch]]