aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHakim El Hattab <hakim.elhattab@gmail.com>2015-05-06 11:25:50 +0200
committerHakim El Hattab <hakim.elhattab@gmail.com>2015-05-06 11:25:58 +0200
commit207b0c71ede4a37ec06797802c22e7c5d61346f6 (patch)
tree82adb5c2337b857b33c8a53ea1013a56cfaa513f
parente67dc9251a38d19cf588eb226d32a67f4d71c7d7 (diff)
downloadfosdem-2018-presentation-207b0c71ede4a37ec06797802c22e7c5d61346f6.tar
fosdem-2018-presentation-207b0c71ede4a37ec06797802c22e7c5d61346f6.tar.gz
fix lazy load selector error
-rw-r--r--js/reveal.js2
-rw-r--r--test/test.html2
-rw-r--r--test/test.js8
3 files changed, 11 insertions, 1 deletions
diff --git a/js/reveal.js b/js/reveal.js
index 3bd292a..ecba3a9 100644
--- a/js/reveal.js
+++ b/js/reveal.js
@@ -2723,7 +2723,7 @@
slide.style.display = 'block';
// Media elements with data-src attributes
- toArray( slide.querySelectorAll( 'img[data-src]', 'video[data-src]', 'audio[data-src]' ) ).forEach( function( element ) {
+ toArray( slide.querySelectorAll( 'img[data-src], video[data-src], audio[data-src]' ) ).forEach( function( element ) {
element.setAttribute( 'src', element.getAttribute( 'data-src' ) );
element.removeAttribute( 'data-src' );
} );
diff --git a/test/test.html b/test/test.html
index 93de5b1..34cf832 100644
--- a/test/test.html
+++ b/test/test.html
@@ -22,6 +22,8 @@
<section data-background-image="examples/assets/image1.png">
<h1>1</h1>
<img data-src="fake-url.png">
+ <video data-src="fake-url.mp4"></video>
+ <audio data-src="fake-url.mp3"></audio>
</section>
<section>
diff --git a/test/test.js b/test/test.js
index ff32ee8..79ff81e 100644
--- a/test/test.js
+++ b/test/test.js
@@ -495,6 +495,14 @@ Reveal.addEventListener( 'ready', function() {
strictEqual( document.querySelectorAll( '.reveal section img[src]' ).length, 1, 'Image source has been set' );
});
+ test( 'video with data-src', function() {
+ strictEqual( document.querySelectorAll( '.reveal section video[src]' ).length, 1, 'Video source has been set' );
+ });
+
+ test( 'audio with data-src', function() {
+ strictEqual( document.querySelectorAll( '.reveal section audio[src]' ).length, 1, 'Audio source has been set' );
+ });
+
test( 'iframe with data-src', function() {
Reveal.slide( 0, 0 );
strictEqual( document.querySelectorAll( '.reveal section iframe[src]' ).length, 0, 'Iframe source is not set' );