From 70c43e152a076ca7de4226f8ac9291b7d8840741 Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Sat, 28 Feb 2004 07:48:28 +0000 Subject: note bug in assert_connection_ok svn:r1159 --- src/or/connection.c | 8 ++++++-- src/or/onion.c | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/or/connection.c b/src/or/connection.c index 3b1f6d963..6728ae5e3 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -840,9 +840,13 @@ void assert_connection_ok(connection_t *conn, time_t now) assert(!conn->tls); } else { if(conn->state == OR_CONN_STATE_OPEN) { - assert(conn->bandwidth > 0); + /* assert(conn->bandwidth > 0); */ + /* the above isn't necessarily true: if we just did a TLS + * handshake but we didn't recognize the other peer, or it + * gave a bad cert/etc, then we won't have assigned bandwidth, + * yet it will be open. -RD + */ assert(conn->receiver_bucket >= 0); -// assert(conn->receiver_bucket <= 10*conn->bandwidth); } assert(conn->addr && conn->port); assert(conn->address); diff --git a/src/or/onion.c b/src/or/onion.c index 5768c41e6..13e22dd19 100644 --- a/src/or/onion.c +++ b/src/or/onion.c @@ -334,7 +334,7 @@ static routerinfo_t *choose_good_exit_server(routerlist_t *dir) smartlist_free(sl); tor_free(n_supported); if(router) { - log_fn(LOG_WARN, "Chose exit server '%s'", router->nickname); + log_fn(LOG_INFO, "Chose exit server '%s'", router->nickname); return router; } log_fn(LOG_WARN, "No exit routers seem to be running; can't choose an exit."); -- cgit v1.2.3