From 43414eb98821d3b5c6c65181d7545ce938f82c8e Mon Sep 17 00:00:00 2001 From: Robert Ransom Date: Thu, 20 Jan 2011 11:17:57 -0800 Subject: Fix bounds-checking in policy_summarize Found by piebeer. --- src/or/policies.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/or/policies.c') diff --git a/src/or/policies.c b/src/or/policies.c index d4b4a07c5..0a8fd7328 100644 --- a/src/or/policies.c +++ b/src/or/policies.c @@ -1209,8 +1209,8 @@ policy_summarize(smartlist_t *policy) accepts_str = smartlist_join_strings(accepts, ",", 0, &accepts_len); rejects_str = smartlist_join_strings(rejects, ",", 0, &rejects_len); - if (rejects_len > MAX_EXITPOLICY_SUMMARY_LEN && - accepts_len > MAX_EXITPOLICY_SUMMARY_LEN) { + if (rejects_len > MAX_EXITPOLICY_SUMMARY_LEN-strlen("reject")-1 && + accepts_len > MAX_EXITPOLICY_SUMMARY_LEN-strlen("accept")-1) { char *c; shorter_str = accepts_str; prefix = "accept"; -- cgit v1.2.3