From af53e4bd1c9aa655ce4faacb957ad7603b9c4825 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Tue, 10 Jun 2014 22:41:13 -0400 Subject: Move circuit-id-in-use check for CREATE cells to before all other checks This means that we never send a DESTROY cell in response to an attempt to CREATE an existing circuit. Fixes bug 12191. --- changes/bug12191 | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 changes/bug12191 (limited to 'changes') diff --git a/changes/bug12191 b/changes/bug12191 new file mode 100644 index 000000000..7fe1c550b --- /dev/null +++ b/changes/bug12191 @@ -0,0 +1,6 @@ + o Minor bugfixes: + + - We now drop CREATE cells for already-existent circuit IDs, regardless + of other factors that might otherwise have called for DESTROY cells. + Fixes bug 12191; bugfix on 0.2.??? + -- cgit v1.2.3 From f9f450d688cc74403393dbe579ca9d92d98bfe13 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 11 Jun 2014 09:33:20 -0400 Subject: Also raise the check for 0 circuit ID in created cell. And add a comment about why conditions that would cause us to drop a cell should get checked before actions that would cause us to send a destroy cell. Spotted by 'cypherpunks'. And note that these issues have been present since 0.0.8pre1 (commit 0da256ef), where we added a "shutting down" state, and started responding to all create cells with DESTROY when shutting down. --- changes/bug12191 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'changes') diff --git a/changes/bug12191 b/changes/bug12191 index 7fe1c550b..77589ab31 100644 --- a/changes/bug12191 +++ b/changes/bug12191 @@ -1,6 +1,7 @@ o Minor bugfixes: - - We now drop CREATE cells for already-existent circuit IDs, regardless - of other factors that might otherwise have called for DESTROY cells. - Fixes bug 12191; bugfix on 0.2.??? + - We now drop CREATE cells for already-existent circuit IDs and + for zero-valued circuit IDs, regardless of other factors that + might otherwise have called for DESTROY cells. Fixes bug 12191; + bugfix on 0.0.8pre1. -- cgit v1.2.3