From a1c5a807d071178fb57910711854d3610c1c2f01 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Thu, 27 Sep 2007 16:41:42 +0000 Subject: r15418@catbus: nickm | 2007-09-27 12:37:59 -0400 Fix a stupid logic error in authority_cert_get_by_sk_digest: the presence of an authority lacking a v3 cert does not mean that subsequent authorities lack them too. svn:r11668 --- ChangeLog | 4 ++++ src/or/routerlist.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index da5de5307..586c56db6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,10 @@ Changes in version 0.2.0.8-alpha - 2007-??-?? OR address is readable, set the port correctly. (Previously we were reporting the dir port.) Bugfix on 0.1.2.x. + o Minor bugfixes (v3 directory code): + - Fix logic to look up a cert by its signing key digest. Bugfix on + 0.2.0.7-alpha. + Changes in version 0.2.0.7-alpha - 2007-09-21 o New directory authorities: - Set up moria1 and tor26 as the first v3 directory authorities. See diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 41dbd126b..29b80735a 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -388,7 +388,7 @@ authority_cert_get_by_sk_digest(const char *sk_digest) SMARTLIST_FOREACH(trusted_dir_servers, trusted_dir_server_t *, ds, { if (!ds->v3_certs) - return NULL; + continue; SMARTLIST_FOREACH(ds->v3_certs, authority_cert_t *, cert, { if (!memcmp(cert->signing_key_digest, sk_digest, DIGEST_LEN)) -- cgit v1.2.3