aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
| * | | | | | | | | Fix ancient code that only checked circ_id, not circ_id and chanNick Mathewson2014-06-03
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code mis-handled the case where a circuit got the same circuit ID in both directions. I found three instances of it in the codebase, by grepping for [pn]_circ_id. Because of the issue in command_process_relay_cell(), this would have made roughly one circuit in a million completely nonfunctional. Fixes bug 12195.
* | | | | | | | | Don't try to fetch bridge descriptors when DisableNetwork is setNick Mathewson2014-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Patch from Roger; changes file by me. Fixes 10405; bugfix on 0.2.3.9-alpha, where DisableNetwork was introduced.
* | | | | | | | | Merge remote-tracking branch 'public/bug12170_024_v2'Nick Mathewson2014-06-02
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | |
| * | | | | | | | Avoid needless router_dir_info_has_changed from router_set_statusNick Mathewson2014-06-02
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On some profiles of Andrea's from #11332, I found that a great deal of time can still be attributed to functions called from update_router_have_minimum_dir_info(). This is making our digestmap, tor_memeq, and siphash functions take a much bigger portion of runtime than they really should. If we're calling update_router_have_minimum_dir_info() too often, that's because we're calling router_dir_info_changed() too often. And it looks like most of the callers of router_dir_info_changed() are coming as tail-calls from router_set_status() as invoked by channel_do_open_actions(). But we don't need to call router_dir_info_changed() so much! (I'm not quite sure we need to call it from here at all, but...) Surely we don't need to call it from router_set_status when the router's status has not actually changed. This patch makes us call router_dir_info_changed() from router_set_status only when we are changing the router's status. Fix for bug 12170. This is leftover from our fix back in 273ee3e81 in 0.1.2.1-alpha, where we started caching the value of update_router_have_minimum_dir_info().
| * | | | | | | Bump maint-0.2.4 version to 0.2.4.22-devNick Mathewson2014-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (See discussion on #9553)
* | | | | | | | sandbox: allow enough setsockopt to make ConstrainedSockets workNick Mathewson2014-05-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes bug 12139; bugfix on 0.2.5.1-alpha
* | | | | | | | sandbox: permit listen(2)Nick Mathewson2014-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for 12115; bugfix on 0.2.5.1-alpha
* | | | | | | | sandbox: Allow DirPortFrontPage unconditionally if it's setNick Mathewson2014-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes 12114; bug not in any release. Improves fix for 12028
* | | | | | | | Log the errno value if seccomp_load() fails.Nick Mathewson2014-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (This is how I found out I was trying to test with a kernel too old for seccomp. I think.)
* | | | | | | | Make sandbox.c compile on armNick Mathewson2014-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a minimal set of changes for compilation; I need a more recent kernel to test this stuff.
* | | | | | | | sandbox: Correct fix for hs part of 12064Nick Mathewson2014-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bugfix on cfd0ee514c279bc6c7b; bug not in any released version of tor
* | | | | | | | Merge branch 'bug11965_v2'Nick Mathewson2014-05-23
|\ \ \ \ \ \ \ \
| * | | | | | | | Postpone fetches based on should_delay_dir_fetch(), not DisableNetworkNick Mathewson2014-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this fix, when running with bridges, we would try fetching directory info far too early, and have up to a 60 second delay if we started with bridge descriptors available. Fixes bug 11965. Fix on 0.2.3.6-alpha, arma thinks.
* | | | | | | | | sandbox: allow reading of hidden service configuration files.Nick Mathewson2014-05-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes part of 12064
* | | | | | | | | sandbox: refactor string-based option-unchanged tests to use a macroNick Mathewson2014-05-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was too much code duplication in doing it the old way, and I nearly made a copy-and-paste error in the last commit.
* | | | | | | | | sandbox: allow access to cookie files, approved-routersNick Mathewson2014-05-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes part of 12064
* | | | | | | | | sandbox: allow access to various stats/*-stats filesMichael Wolf2014-05-22
| |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | Fix for 12064 part 1
* | | | | | | | Merge remote-tracking branch 'andrea/bug11476'Nick Mathewson2014-05-22
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | Eliminate #ifdef ENABLE_MEMPOOLS in packed_cell_new/free()Andrea Shepard2014-05-21
| | | | | | | |
| * | | | | | | Add --disable-mempools configure optionAndrea Shepard2014-05-12
| | | | | | | |
* | | | | | | | sandbox: permit gettid, sched_getaffinityNick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are needed under some circumstances if we are running with expensive-hardening and sandbox at the same time. fixes 11477, bugfix on 0.2.5.4-alpha (where we introduced expensive-hardening)
* | | | | | | | fix a wide lineNick Mathewson2014-05-20
| | | | | | | |
* | | | | | | | sandbox: support logfile rotationNick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 12032; bugfix on 0.2.5.1-alpha
* | | | | | | | sandbox: tolerate reloading with DirPortFrontPage setNick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, don't tolerate changing DirPortFrontPage. Fixes bug 12028; bugfix on 0.2.5.1-alpha.
* | | | | | | | sandbox: Disallow options which would make us call exec()Nick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | None of the things we might exec() can possibly run under the sanbox, so rather than crash later, we have to refuse to accept the configuration nice and early. The longer-term solution is to have an exec() helper, but wow is that risky. fixes 12043; bugfix on 0.2.5.1-alpha
* | | | | | | | sandbox: Permit access to stats/dirreq-statsNick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents a crash when rotating logs with dirreq-stats enabled fixes 12035; bugfix on 0.2.5.1-alpha.
* | | | | | | | Oops; permit rename with the correct filenameNick Mathewson2014-05-20
| | | | | | | |
* | | | | | | | Fix a sentence that I neverNick Mathewson2014-05-20
| | | | | | | |
* | | | | | | | Sandbox: allow access to stats/bridge-statsNick Mathewson2014-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for 12041; bugfix on 0.2.5.1-alpha.
* | | | | | | | note a comment that nickm didn't finishRoger Dingledine2014-05-17
| | | | | | | |
* | | | | | | | Merge remote-tracking branch 'public/bug11469_024'Nick Mathewson2014-05-15
|\ \ \ \ \ \ \ \
| * | | | | | | | Use DirPort for uploading descriptors.Nick Mathewson2014-05-14
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we converted the horrible set of options that previously controlled "use ORPort or DirPort? Anonymously or Non-anonymouly?" to a single 'indirection' argument, we missed directory_post_to_dirservers. The problematic code was introduced in 5cbeb6080, which went into 0.2.4.3-alpha. This is a fix for bug 11469.
| * | | | | | | Merge commit 'bb9b4c37f8e7f5cf78918f382e90d8b11ff42551' into maint-0.2.4Nick Mathewson2014-05-07
| |\ \ \ \ \ \ \
| * \ \ \ \ \ \ \ Merge remote-tracking branch 'public/ticket11528_024' into maint-0.2.4Nick Mathewson2014-05-07
| |\ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ Merge remote-tracking branch 'public/bug11513_024' into maint-0.2.4Nick Mathewson2014-05-07
| |\ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ \ Merge remote-tracking branch 'public/update_ciphers_ff28' into maint-0.2.4Nick Mathewson2014-05-07
| |\ \ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ \ \ Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2014-05-01
| |\ \ \ \ \ \ \ \ \ \ \ | | | |_|_|_|_|/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/or/microdesc.c
| | * | | | | | | | | | Downgrade bug 7164 warning to INFONick Mathewson2014-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 0.2.5.x warning is the one that might help us track this down; the warnings in stable are just annoying users over and over and over.
* | | | | | | | | | | | whitespace fix, moreNick Mathewson2014-05-14
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'bug11946'Nick Mathewson2014-05-14
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Improved comments on bug11946 fixNick Mathewson2014-05-14
| | | | | | | | | | | | |
| * | | | | | | | | | | | Use tor_getpw{nam,uid} wrappers to fix bug 11946Nick Mathewson2014-05-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running with User set, we frequently try to look up our information in the user database (e.g., /etc/passwd). The seccomp2 sandbox setup doesn't let us open /etc/passwd, and probably shouldn't. To fix this, we have a pair of wrappers for getpwnam and getpwuid. When a real call to getpwnam or getpwuid fails, they fall back to a cached value, if the uid/gid matches. (Granting access to /etc/passwd isn't possible with the way we handle opening files through the sandbox. It's not desirable either.)
| * | | | | | | | | | | | Add a pair of wrapper functions: tor_getpwnam() and tor_getpwuid()Nick Mathewson2014-05-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll use these to deal with being unable to access the user DB after we install the sandbox, to fix bug 11946.
* | | | | | | | | | | | | whitespace fixNick Mathewson2014-05-14
|/ / / / / / / / / / / /
* | | | | | | | | | | | Merge branch 'bug9781_v2'Nick Mathewson2014-05-12
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Log an error reply from tor-fw-helper correctly.Nick Mathewson2014-05-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for bug 9781; bugfix on cd05f35d2cdf50 in 0.2.4.2-alpha.
| * | | | | | | | | | | | Split portfw-error-logging code into a new function.Nick Mathewson2014-05-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No code has changed; only moved. Part of a fix for 9781.
* | | | | | | | | | | | | Fix compilation of test_status.c with MSVCGisle Vanem2014-05-12
| | | | | | | | | | | | |
* | | | | | | | | | | | | fix whitespaceNick Mathewson2014-05-11
| | | | | | | | | | | | |
* | | | | | | | | | | | | Quench clang's complaints with -Wshorten-64-to-32 when time_t is not long.dana koch2014-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On OpenBSD 5.4, time_t is a 32-bit integer. These instances contain implicit treatment of long and time_t as comparable types, so explicitly cast to time_t.